Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve type info in fingerprint etc. #5903

Closed
bep opened this issue Apr 26, 2019 · 0 comments · Fixed by #6265

Comments

@bep
Copy link
Member

commented Apr 26, 2019

As it is now:

{{ ($myimg | fingerprint ).Width }}

Fails because it's not an Image anymore.

@bep bep self-assigned this Apr 26, 2019

@bep bep added this to the v0.56 milestone Apr 26, 2019

@bep bep added the Enhancement label Apr 26, 2019

@bep bep modified the milestones: v0.56, v0.57 Jun 14, 2019

@bep bep modified the milestones: v0.57, v0.58 Jul 31, 2019

@bep bep modified the milestones: v0.58, v0.59 Aug 13, 2019

bep added a commit to bep/hugo that referenced this issue Aug 18, 2019
bep added a commit to bep/hugo that referenced this issue Aug 21, 2019
bep added a commit to bep/hugo that referenced this issue Aug 21, 2019
bep added a commit to bep/hugo that referenced this issue Aug 21, 2019
bep added a commit to bep/hugo that referenced this issue Aug 23, 2019
bep added a commit to bep/hugo that referenced this issue Aug 25, 2019
bep added a commit to bep/hugo that referenced this issue Aug 25, 2019
bep added a commit to bep/hugo that referenced this issue Aug 25, 2019
bep added a commit to bep/hugo that referenced this issue Aug 26, 2019
Image resource refactor
This commit pulls most of the image related logic into its own package, to make it easier to reason about and extend.

This is also a rewrite of the transformation logic used in Hugo Pipes, mostly to allow constructs like the one below:

    {{ ($myimg | fingerprint ).Width }}

Fixes gohugoio#5903
Fixes gohugoio#6234
bep added a commit to bep/hugo that referenced this issue Aug 26, 2019
Image resource refactor
This commit pulls most of the image related logic into its own package, to make it easier to reason about and extend.

This is also a rewrite of the transformation logic used in Hugo Pipes, mostly to allow constructs like the one below:

    {{ ($myimg | fingerprint ).Width }}

Fixes gohugoio#5903
Fixes gohugoio#6234
Fixes gohugoio#6266
bep added a commit to bep/hugo that referenced this issue Aug 26, 2019
Image resource refactor
This commit pulls most of the image related logic into its own package, to make it easier to reason about and extend.

This is also a rewrite of the transformation logic used in Hugo Pipes, mostly to allow constructs like the one below:

    {{ ($myimg | fingerprint ).Width }}

Fixes gohugoio#5903
Fixes gohugoio#6234
Fixes gohugoio#6266
bep added a commit to bep/hugo that referenced this issue Aug 26, 2019
Image resource refactor
This commit pulls most of the image related logic into its own package, to make it easier to reason about and extend.

This is also a rewrite of the transformation logic used in Hugo Pipes, mostly to allow constructs like the one below:

    {{ ($myimg | fingerprint ).Width }}

Fixes gohugoio#5903
Fixes gohugoio#6234
Fixes gohugoio#6266
bep added a commit to bep/hugo that referenced this issue Aug 26, 2019
Image resource refactor
This commit pulls most of the image related logic into its own package, to make it easier to reason about and extend.

This is also a rewrite of the transformation logic used in Hugo Pipes, mostly to allow constructs like the one below:

    {{ ($myimg | fingerprint ).Width }}

Fixes gohugoio#5903
Fixes gohugoio#6234
Fixes gohugoio#6266
bep added a commit to bep/hugo that referenced this issue Aug 26, 2019
Image resource refactor
This commit pulls most of the image related logic into its own package, to make it easier to reason about and extend.

This is also a rewrite of the transformation logic used in Hugo Pipes, mostly to allow constructs like the one below:

    {{ ($myimg | fingerprint ).Width }}

Fixes gohugoio#5903
Fixes gohugoio#6234
Fixes gohugoio#6266

@bep bep closed this in f9978ed Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.