Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Goldmark the new default markdown renderer #5963

Closed
bep opened this issue May 16, 2019 · 7 comments
Closed

Make Goldmark the new default markdown renderer #5963

bep opened this issue May 16, 2019 · 7 comments
Milestone

Comments

@bep
Copy link
Member

@bep bep commented May 16, 2019

https://github.com/yuin/goldmark

@bep bep added this to the v0.56 milestone May 16, 2019
@bep
Copy link
Member Author

@bep bep commented May 16, 2019

I've been looking for a solid CommonMark compliant MD processor for a long time, and from what I've seen the above looks very solid.

/cc @kaushalmodi @spf13 and gang.

/cc @yuin I assume you wouldn't mind if we used this in Hugo? I notice that it's already at > v1 so that looks promising.

Loading

@yuin
Copy link

@yuin yuin commented May 16, 2019

@bep Yes, goldmark passed all commonmark 0.29 spec tests . Extensions are also tested.

Extensibility that blackfridy does not have should come in useful for applications like Hugo, I would be glad if goldmark could help to Hugo :)

Loading

@kaushalmodi
Copy link
Member

@kaushalmodi kaushalmodi commented May 16, 2019

@bep Looks great! Please let this upgrade marinate in the master branch for a while (1 week or so) so that I can upgrade ox-hugo in parallel to support it.

Loading

@bep bep removed this from the v0.56 milestone Jun 14, 2019
@bep bep added this to the v0.57 milestone Jun 14, 2019
@bep bep removed this from the v0.56 milestone Jun 14, 2019
@bep bep added this to the v0.57 milestone Jun 14, 2019
@bep bep removed this from the v0.57 milestone Jul 31, 2019
@bep bep added this to the v0.58 milestone Jul 31, 2019
@bep bep removed this from the v0.58 milestone Aug 13, 2019
@bep bep added this to the v0.59 milestone Aug 13, 2019
@bep bep removed this from the v0.59 milestone Aug 13, 2019
@bep bep added this to the v0.57 milestone Aug 13, 2019
@bep bep removed this from the v0.57 milestone Aug 13, 2019
@bep bep added this to the v0.58 milestone Aug 13, 2019
@bep bep pinned this issue Aug 13, 2019
@bep bep removed this from the v0.58 milestone Sep 2, 2019
@bep bep added this to the v0.59 milestone Sep 2, 2019
@bep bep removed this from the v0.59 milestone Sep 6, 2019
@bep bep added this to the v0.60 milestone Sep 6, 2019
@evankanderson
Copy link
Contributor

@evankanderson evankanderson commented Sep 30, 2019

Is this in progress or in the icebox pending developer work?

Loading

@bep bep changed the title Investigate use of Goldmark Make Goldmark the new default markdown renderer Sep 30, 2019
bep added a commit to bep/hugo that referenced this issue Nov 11, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
bep added a commit to bep/hugo that referenced this issue Nov 11, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
bep added a commit to bep/hugo that referenced this issue Nov 11, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
bep added a commit to bep/hugo that referenced this issue Nov 11, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
bep added a commit to bep/hugo that referenced this issue Nov 11, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
bep added a commit to bep/hugo that referenced this issue Nov 12, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 14, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 15, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 16, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 16, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 17, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 19, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
bep added a commit to bep/hugo that referenced this issue Nov 23, 2019
This commit adds the fast and CommonMark compliant Goldmark as the new default markdown handler in Hugo.

If you want to continue using BlackFriday as the default for md/markdown extensions, you can use this configuration:

```toml
[markup]
defaultMarkdownHandler="blackfriday"
```

Fixes gohugoio#5963
Fixes gohugoio#1778
Fixes gohugoio#6355
@bep bep closed this in bfb9613 Nov 23, 2019
@bep bep unpinned this issue Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants