Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live reload fails when 1 file changes and that file is a CSS/SCSS with @import #6106

Closed
bep opened this issue Jul 22, 2019 · 0 comments

Comments

@bep
Copy link
Member

commented Jul 22, 2019

This was an head scratcher for me as I had only 1 site failing to autoreload when I maded changes to a SCSS. This looks like a bug in https://github.com/livereload/livereload-js and you will typically see this in the Chrome console:

Uncaught TypeError: link.getAttribute is not a function
    at Reloader.linkHref (livereload.js?port=1313&mindelay=10&v=2:1744)
    at livereload.js?port=1313&mindelay=10&v=2:1642
    at pickBestMatch (livereload.js?port=1313&mindelay=10&v=2:1421)
    at Reloader.reloadStylesheet (livereload.js?port=1313&mindelay=10&v=2:1642)
    at Reloader.reload (livereload.js?port=1313&mindelay=10&v=2:1499)
    at LiveReload.performReload (livereload.js?port=1313&mindelay=10&v=2:1089)
    at Object.message (livereload.js?port=1313&mindelay=10&v=2:1069)
    at Object.message (livereload.js?port=1313&mindelay=10&v=2:708)
    at Parser.process (livereload.js?port=1313&mindelay=10&v=2:1321)
    at Connector._onmessage (livereload.js?port=1313&mindelay=10&v=2:840)

For the above to happen:

  • You need an @import in your styles
  • The change must only result in 1 changed (CSS) file; else we fall back to a hard browser refresh (and that works fine)

@bep bep added Bug Upstream labels Jul 22, 2019

@bep bep added this to the v0.56 milestone Jul 22, 2019

@bep bep self-assigned this Jul 22, 2019

@bep bep closed this in 2fc0abd Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.