Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache processed images by their source path #6269

Closed
bep opened this issue Aug 26, 2019 · 1 comment · Fixed by #6301

Comments

@bep
Copy link
Member

commented Aug 26, 2019

No description provided.

@bep bep added this to the v0.58 milestone Aug 26, 2019

@bep bep self-assigned this Aug 26, 2019

@bep bep added the Bug label Sep 3, 2019

@bep

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

OK, I checked. We currently cache by their target path:

/bundle/sunset_hu59e56ffff1bc1d8d122b1403d34e039f_90587_200x200_resize_q75_box.jpg bundle/sunset.jpg
/nn/bundle/sunset_hu59e56ffff1bc1d8d122b1403d34e039f_90587_200x200_resize_q75_box.jpg bundle/sunset.jpg
/fr/bundle/sunset_hu59e56ffff1bc1d8d122b1403d34e039f_90587_200x200_resize_q75_box.jpg bundle/sunset.jpg

This works, but it means that we do unneeded image processing and wastes disk space in multilingual setups.

@bep bep changed the title Check image cache duplication for languages Cache processed images by their source path Sep 3, 2019

bep added a commit to bep/hugo that referenced this issue Sep 3, 2019
bep added a commit to bep/hugo that referenced this issue Sep 3, 2019
bep added a commit to bep/hugo that referenced this issue Sep 3, 2019

@bep bep closed this in #6301 Sep 3, 2019

bep added a commit that referenced this issue Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.