Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing images doesn't work when fingerprinting #6284

Closed
carlmjohnson opened this issue Aug 30, 2019 · 2 comments

Comments

@carlmjohnson
Copy link

commented Aug 30, 2019

I have the following snippet in a partial used for a page bundle:

      {{ with index (.Resources.ByType "image") 0  }}
        {{ $img := . }}
        {{ $imgSmall := .Resize "350x" | fingerprint }}
        <figure class="image">
          <img
            alt="{{ $img.Title }}"
            src="{{ $imgSmall.RelPermalink }}"
          >
        </figure>
      {{ end}}

I found that it's not resizing the image unless I remove | fingerprint.

@carlmjohnson

This comment has been minimized.

Copy link
Author

commented Aug 30, 2019

$ hugo version
Hugo Static Site Generator v0.57.2/extended darwin/amd64 BuildDate: unknown

Brew installed.

@bep bep added this to the v0.58 milestone Sep 2, 2019

@bep

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

I will check; I'm pretty sure this is fixed in the latest source, but I'll add a test for it. But note that fingerprinting resized images for "cache busting" is not needed -- as their filename will change when the image changes.

@bep bep closed this in 45d7988 Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.