Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure support breaks Solaris compatibility #6324

Open
fazalmajid opened this issue Sep 12, 2019 · 4 comments

Comments

@fazalmajid
Copy link
Contributor

commented Sep 12, 2019

local64 ~/go>go get github.com/gohugoio/hugo
# github.com/Azure/azure-storage-blob-go/azblob
src/github.com/Azure/azure-storage-blob-go/azblob/highlevel.go:144:7: undefined: mmf
src/github.com/Azure/azure-storage-blob-go/azblob/highlevel.go:146:12: undefined: newMMF
src/github.com/Azure/azure-storage-blob-go/azblob/highlevel.go:275:13: undefined: newMMF

I have zero interest in Azure, and this is breaking my SmartOS hosted environment. Is there a way to disable Azure support in Hugo at compile time?

@bep bep added the Bug label Sep 12, 2019
@bep bep added this to the v0.59 milestone Sep 12, 2019
@bep

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

Is there a way to disable Azure support in Hugo at compile time?

Currently, no. But we should at least make sure to turn it off for unsupported platforms.

You're the first Hugo user on Solaris I've heard of. I thought we had a bug in file watching on Solaris (in fsnotify)

/cc @vangent

https://github.com/Azure/azure-storage-blob-go/blob/8a1deeeabe0a24f918d29630ede0da2a1c8f3b2f/azblob/zc_mmf_unix.go#L12

@vangent

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

It looks like the Azure library is working on this already:

@bep bep added the Upstream label Sep 12, 2019
@fazalmajid

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@bep Yes, it helps me feel special and unique that way :-)

The fsnotify issue fsnotify/fsnotify#196 is not a problem, I've been running Hugo on SmartOS since I converted over from WP two years ago. Then again I don't use Hugo in watch mode.

Would you be OK if I restructured deploy/deploy.go with build tags so Go Cloud Azure BLOB support isn't built on Solaris? There's no actual code, the Azure support is entirely done as a side-effect of importing the module, just as with database/sql DB-specific drivers, so it could be as simple as adding a deploy/deploy_azure.go that imports the module and has !solaris build tags.

@bep

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@fazalmajid sure, I'll merge that. We can possibly revisit this later at some point.

I have had my share of Solaris (Sun) use myself in my work life, and I liked it a lot.

fazalmajid added a commit to fazalmajid/hugo that referenced this issue Sep 12, 2019
bep added a commit that referenced this issue Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.