Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java syntax broken highlight #6476

Closed
RichyHBM opened this issue Nov 4, 2019 · 4 comments · Fixed by #6477
Closed

Java syntax broken highlight #6476

RichyHBM opened this issue Nov 4, 2019 · 4 comments · Fixed by #6477
Labels
Milestone

Comments

@RichyHBM
Copy link

@RichyHBM RichyHBM commented Nov 4, 2019

What version of Hugo are you using (hugo version)?

$ hugo version

Hugo Static Site Generator v0.59.1-D5DAB232 windows/amd64 BuildDate: 2019-10-31T15:22:43Z

Does this issue reproduce with the latest release?

Yes

I am using chroma, or the default in hugo and noticed that upgrading from 0.54 to 0.59.1 has broken highlighting java code.

Here is a before and after of the code I am referring to:

Before: 0.54
chrome_No3aArXYPk

After: 0.59.1
chrome_ApdI1HlPQw

@bep

This comment has been minimized.

Copy link
Member

@bep bep commented Nov 4, 2019

This looks to be an issue with Chroma and I would appreciate if you could create and issue at https://github.com/alecthomas/chroma/issues which is closer to where it needs to be fixed.

@anthonyfok

This comment has been minimized.

Copy link
Contributor

@anthonyfok anthonyfok commented Nov 5, 2019

bep is right: I was able to reproduce the issue with the chroma command-line tool, v0.6.8:

chroma -s monokai --html sample.java

@RichyHBM, I should have let you do the honour, but I got intrigued by this issue that I went ahead and filed this bug at alecthomas/chroma#297, hence this note to you to avoid duplication of work.

Cheers!

@anthonyfok anthonyfok added this to the v0.59.2 milestone Nov 5, 2019
anthonyfok added a commit to anthonyfok/hugo that referenced this issue Nov 5, 2019
to fix Java syntax highlighting

Fixes gohugoio#6476
anthonyfok added a commit to anthonyfok/hugo that referenced this issue Nov 5, 2019
@anthonyfok

This comment has been minimized.

Copy link
Contributor

@anthonyfok anthonyfok commented Nov 5, 2019

Special thanks to upstream author of Chroma for another amazing speedy fix alecthomas/chroma@3aaf3e5 (in mere 20 minutes of receiving the report):

Thanks for the report, fixed!

For clarity, this bug was in the lexer and existed prior to bbc59ac, it just wasn't visible.

Wow, and Chroma v0.6.9 with the fix has just been released too! Woohoo!

@bep bep closed this in #6477 Nov 5, 2019
bep added a commit that referenced this issue Nov 5, 2019
@RichyHBM

This comment has been minimized.

Copy link
Author

@RichyHBM RichyHBM commented Nov 5, 2019

Wowza, great work guys, very speedy!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.