Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default timeout value #6502

Closed
bep opened this issue Nov 12, 2019 · 1 comment
Closed

Increase default timeout value #6502

bep opened this issue Nov 12, 2019 · 1 comment
Labels
Milestone

Comments

@bep
Copy link
Member

@bep bep commented Nov 12, 2019

See #6501 etc.

The main motivation behind the timeout is to bail out of circular loops, and if that is 10 seconds or 30 seconds does not matter too much.

/cc @anthonyfok I noticed you did a recent change in Mage file. Maybe we should agree on a new default "higher value"

@bep bep added the Enhancement label Nov 12, 2019
@bep bep added this to the v0.60 milestone Nov 12, 2019
@anthonyfok

This comment has been minimized.

Copy link
Contributor

@anthonyfok anthonyfok commented Nov 14, 2019

/cc @anthonyfok I noticed you did a recent change in Mage file. Maybe we should agree on a new default "higher value"

I did not set a custom timeout to magefile.go, but rather, just in .travis.yml, i.e. setting the environment variable HUGO_TIMEOUT=30000 specifically for the mage -v check run on arm64 (or non-amd64) because I thought it was somewhat specific to the current ARM64 hardware that Travis CI uses.

I am certainly fine with increasing the default timeout value to whatever is appropriate to fix e.g. #6501. The only concern I could think of is that a longer timeout, if not accompanied by a message notifying what Hugo is currently doing, might leave the end user wondering why Hugo seemingly becomes unresponsive. (though probably a non-issue)

bep added a commit to bep/hugo that referenced this issue Nov 25, 2019
bep added a commit to bep/hugo that referenced this issue Nov 25, 2019
bep added a commit to bep/hugo that referenced this issue Nov 25, 2019
@bep bep closed this in a8e9f83 Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.