Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support footnote return links #6551

Closed
Brixy opened this issue Nov 28, 2019 · 2 comments · Fixed by #6556
Closed

Support footnote return links #6551

Brixy opened this issue Nov 28, 2019 · 2 comments · Fixed by #6556
Labels
Milestone

Comments

@Brixy
Copy link

@Brixy Brixy commented Nov 28, 2019

Version 0.60.0; yes, latest Hugo version is used.

Hugo 0.60.0 + Gold is just great! Thank you!

The footnote extension seems to not support return links although they are part of the PHP Markdown extra.

It is difficult for readers to navigate between the text and footnotes.

Is there a way to enable (and modify) footnote return links?

Thank you!

Markdown:

That's some text with a footnote.[^1]

[^1]: And that's the footnote.

Output:

…
<section class="footnotes" role="doc-endnotes"><hr><ol><li id="fn:1" role="doc-endnote"><p>And that's the footnote.</p></li></ol></section>
@bep bep added the Upstream label Nov 28, 2019
@bep

This comment has been minimized.

Copy link
Member

@bep bep commented Nov 28, 2019

I agree, but I think a fix fits more natural into Goldmark (so more people can appreciate it).

Can you create an issue here: https://github.com/yuin/goldmark/issues

Link back to this issue so we can track it.

@yuin

This comment has been minimized.

Copy link

@yuin yuin commented Nov 29, 2019

goldmark author here, I've added back links to the footnote and released new version.

@bep bep added this to the v0.60.1 milestone Nov 29, 2019
bep added a commit to bep/hugo that referenced this issue Nov 29, 2019
bep added a commit to bep/hugo that referenced this issue Nov 29, 2019
@bep bep closed this in #6556 Nov 29, 2019
bep added a commit that referenced this issue Nov 29, 2019
Fixes #6549
Fixes #6551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.