Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of formatting in table cells #6641

Closed
frerich opened this issue Dec 19, 2019 · 4 comments
Closed

Incorrect handling of formatting in table cells #6641

frerich opened this issue Dec 19, 2019 · 4 comments
Milestone

Comments

@frerich
Copy link

@frerich frerich commented Dec 19, 2019

What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.61.0/extended darwin/amd64 BuildDate: unknown

Does this issue reproduce with the latest release?

Yes.

Given a Markdown table like

Foo|Bar
---|---
`Yoyo`|Dyne

Then pasting it in the (supposedly correct) CommonMark editor at https://commonmark.org/help/tutorial/02-emphasis.html (click the 'Try It' button to get to the Marrkdown editor) produces a table with two rows (one for the header, one for the data) and two rows. In particular, 'Yoyo' . and 'Dyne' are in separate columns, with 'Yoyo' being formatted with a fixed-width font.

With Hugo, the backticks cause 'Yoyo' . and 'Dyne' to get merged into a single column. Removing the backticks (i.e. removing the formatting) causes two columns to be generated again.

@frerich frerich changed the title Incorrect handling of formatting in table . cells Incorrect handling of formatting in table cells Dec 19, 2019
@bep

This comment has been minimized.

Copy link
Member

@bep bep commented Dec 19, 2019

Thanks for the report. This looks like it could be an issue with Goldmark. Could you create an issue at https://github.com/yuin/goldmark/issues and link back to this issue so we could track it?

@bep bep added this to the v0.62 milestone Dec 19, 2019
@frerich

This comment has been minimized.

Copy link
Author

@frerich frerich commented Dec 19, 2019

I considered creating a Goldmark issue but I'm asked to specify which version of Goldmark I'm using - alas, I don't know!

Also, when creating a Goldmark issue, it asks to verify that https://spec.commonmark.org/dingus/ produces different output than Goldmark. Which, in this case, is not the case.

In fact, the CommonMark editor at https://spec.commonmark.org/dingus/ and then one used by https://commonmark.org/help/tutorial/02-emphasis.html (after clicking the 'Try It' button) yield different results (I think the latter generates the more plausible result). So I'm not even sure it's a Goldmark bug or just a wrong expectation on my part based on doing the CommonMark tutorial...

@bep

This comment has been minimized.

Copy link
Member

@bep bep commented Dec 19, 2019

@bep bep closed this in 0453683 Dec 20, 2019
@frerich

This comment has been minimized.

Copy link
Author

@frerich frerich commented Dec 20, 2019

Thanks a lot for creating the Go-based Goldmark issue so quickly - it's great to see how active both you as well as Yuin are. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.