Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not return any value in errorf #6653

Closed
bep opened this issue Dec 20, 2019 · 3 comments
Closed

Do not return any value in errorf #6653

bep opened this issue Dec 20, 2019 · 3 comments
Assignees
Milestone

Comments

@bep
Copy link
Member

@bep bep commented Dec 20, 2019

Related to #6652, but lest take it in a separate issue.

This would probably make sense before we got the server error page, but now it's just annoying, esp. for people who want to publish even if there are ERRORs.

@bep bep added this to the v0.62 milestone Dec 20, 2019
@bep bep self-assigned this Dec 20, 2019
@bep bep closed this in 50cc7fe Dec 21, 2019
@moorereason

This comment has been minimized.

Copy link
Contributor

@moorereason moorereason commented Dec 21, 2019

What about people who expect the build to fail on errorf?

@bep

This comment has been minimized.

Copy link
Member Author

@bep bep commented Dec 21, 2019

What about them?

@moorereason

This comment has been minimized.

Copy link
Contributor

@moorereason moorereason commented Dec 21, 2019

Ignore me. I misunderstood what you were talking about here. 🤦‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.