Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mount source/target mismatches in .GetPage and live reload #6696

Closed
bep opened this issue Jan 1, 2020 · 0 comments
Closed

Handle mount source/target mismatches in .GetPage and live reload #6696

bep opened this issue Jan 1, 2020 · 0 comments
Labels
Bug
Milestone

Comments

@bep
Copy link
Member

@bep bep commented Jan 1, 2020

This is related to #6684

All of this was simpler before we got file mounts. Then what we put in .Path was the source path.

One example config:

[module]
  [[module.mounts]]
    source = "README.md"
    target = "content/_index.md"
  [[module.mounts]]
    source = "blog"
    target = "content/posts"
  [[module.mounts]]
    source = "docs"
    target = "content/docs"

In the above:

  • For the docs mount, the source and target paths matches and everything is OK
  • The two other examples will not work. .GetPage "/README.md" (needed by #6684) will not return anything and when you change that file in server mode, we currently will not be able to correctly match it to a page.
@bep bep added the Bug label Jan 1, 2020
@bep bep added this to the v0.62.1 milestone Jan 1, 2020
bep added a commit to bep/hugo that referenced this issue Jan 1, 2020
This commit is a general improvement of handling if single file mounts.

Fixes gohugoio#6684
Fixes gohugoio#6696
bep added a commit to bep/hugo that referenced this issue Jan 1, 2020
This commit is a general improvement of handling if single file mounts.

Fixes gohugoio#6684
Fixes gohugoio#6696
bep added a commit to bep/hugo that referenced this issue Jan 1, 2020
This commit is a general improvement of handling if single file mounts.

Fixes gohugoio#6684
Fixes gohugoio#6696
@bep bep closed this in ff6253b Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.