Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS @import ERROR after latest commit (1a8af7d) #7063

Closed
pamubay opened this issue Mar 17, 2020 · 1 comment
Closed

SCSS @import ERROR after latest commit (1a8af7d) #7063

pamubay opened this issue Mar 17, 2020 · 1 comment
Labels
Bug
Milestone

Comments

@pamubay
Copy link

@pamubay pamubay commented Mar 17, 2020

What version of Hugo are you using (hugo version)?

Hugo Static Site Generator v0.68.0-DEV-1A8AF7D4/extended linux/amd64 BuildDate: 2020-03-17T09:03:32+0700

Does this issue reproduce with the latest release?

Yes

After this commit 1a8af7d SCSS @import doesnt work.

Error:

Error: Error building site: TOCSS: failed to transform "styles/file.scss" (text/x-scss): SCSS processing failed: file "stdin", line 11, col 16: Undefined variable: "$font-sans". 

The Problem, The RegEx also match the .scss @import

regularCSSImportTo = regexp.MustCompile(`.*(@import "(.*.css)";).*`)

regex_bug

Should be:

.*(@import "(.*\.css)";).*
@bep

This comment has been minimized.

Copy link
Member

@bep bep commented Mar 17, 2020

Thanks! That was a stupid mistake. Odd that I didn't have a test catching it.

@bep bep added the Bug label Mar 17, 2020
@bep bep added this to the v0.67.2 milestone Mar 17, 2020
@bep bep closed this in c7b6d74 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.