Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural possessives and “smart” punctuation #8099

Closed
brycewray opened this issue Dec 28, 2020 · 4 comments
Closed

Plural possessives and “smart” punctuation #8099

brycewray opened this issue Dec 28, 2020 · 4 comments

Comments

@brycewray
Copy link

brycewray commented Dec 28, 2020

I am using Hugo 0.79.1. The issue does occur with this version.

While I suspect it’s Goldmark-caused rather than Hugo-caused, the Goldmark developer seems to require Goldmark issues that are observed in Hugo to be proposed as Hugo issues before he will have anything to do with them. So I’ll start here.

Consider the following text in a Markdown file:

John's dog is named Sam. The Smiths' dog is named Rover.

Expected result: Each apostrophe should be a “smart”/curly apostrophe (’), given the default behavior of Goldmark’s Typographer extension as it works in Hugo.

Actual result: Only the singular possessive (John's dog) has the “smart”/curly apostrophe, while the plural possessive (Smiths' dog) has the “dumb”/straight apostrophe (').

Thanks in advance for any help or consideration this issue may receive.

@Brixy
Copy link

Brixy commented Jan 1, 2021

It seems to be a goldmark issue, indeed.

When using blackfriday, ‘trailing apostrophes’ work:

markup:
  defaultMarkdownHandler: blackfriday

Output:

<p>John&rsquo;s dog is named Sam. The Smiths&rsquo; dog is named Rover.</p>

Happy New Year!

@brycewray
Copy link
Author

Thanks, @Brixy — will file an issue in the Goldmark repo.

@skyfaller
Copy link

Upstream has a stale bot that automatically closed the issue because we didn't constantly comment. The issue has not been fixed, but the upstream author says "I welcome PR from native English writers.", so it could be fixed upstream if we can find someone to help.

Here are two web pages demonstrating the issues:

Can anyone figure out a solution and/or submit a PR for Goldmark? Since Blackfriday is being deprecated, there does not seem to be a good workaround.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants