Skip to content

/ hugo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock config.Get when config section does not exist #8791

Closed
bep opened this issue Jul 26, 2021 · 0 comments
Closed

Deadlock config.Get when config section does not exist #8791

bep opened this issue Jul 26, 2021 · 0 comments
Assignees
@bep
Labels
Bug

Comments

@bep
Copy link
Member

@bep bep commented Jul 26, 2021

We don't have any existing tests failing with this, and I don't know of any Hugo site failing with this, but I think we need to get this fix out sooner rather than later.
@bep bep self-assigned this Jul 26, 2021
@bep bep added the Bug label Jul 26, 2021
bep added a commit to bep/hugo that referenced this issue Jul 26, 2021
@bep
Deprecate Blackfriday and fix a potential deadlock in config
Verified
This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
GPG key ID: 330E6E2BD4859D8F Learn about vigilant mode.
Loading status checks…
e014dfa 
Note that the deadlock has not been seen earlier, in tests on in real Hugo sites.

Fixes gohugoio#8792
Fixes gohugoio#8791
@bep bep mentioned this issue Jul 26, 2021
Merged
@bep bep closed this in #8793 Jul 26, 2021
bep added a commit that referenced this issue Jul 26, 2021
@bep
Deprecate Blackfriday and fix a potential deadlock in config
Loading status checks…
c725222 
Note that the deadlock has not been seen earlier, in tests on in real Hugo sites.

Fixes #8792
Fixes #8791
bep added a commit that referenced this issue Jul 30, 2021
@bep
config: Fix a potential deadlock in config reading
Verified
This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
GPG key ID: 330E6E2BD4859D8F Learn about vigilant mode.
Loading status checks…
94b616b 
Note that the deadlock has not been seen earlier, in tests on in real Hugo sites.

Fixes #8791
@bot-actions bot-actions bot mentioned this issue Aug 2, 2021
Merged
@abtris abtris mentioned this issue Aug 2, 2021
Merged
@abtris abtris mentioned this issue Aug 2, 2021
Merged
@bot-actions bot-actions bot mentioned this issue Aug 4, 2021
Merged
@abtris abtris mentioned this issue Aug 9, 2021
Merged
@abtris abtris mentioned this issue Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bep bep

Labels
Bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Deprecate Blackfriday and fix a potential deadlock in config
1 participant
@bep