Skip to content

/ hugo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade minify to fix ES6 corruption issue. #8831

Closed
bwklein opened this issue Jul 30, 2021 · 2 comments
Closed

Upgrade minify to fix ES6 corruption issue. #8831

bwklein opened this issue Jul 30, 2021 · 2 comments
Milestone
v0.87

Comments

@bwklein
Copy link
Contributor

@bwklein bwklein commented Jul 30, 2021

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.83.1-5AFE0A57+extended linux/amd64 BuildDate=2021-05-02T14:38:05Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?

Requires an update of tdewolff/minify to a version released after 2021-07-29.
tdewolff/minify@9f73f9d

Problem

There was a regression in the minify library that corrupted ES6 format code in <script> tags.
tdewolff/minify#429
This has been resolved, and Hugo just needs to pull in the latest version of the library.
@bep bep added this to the v0.88 milestone Jul 30, 2021
@bep bep removed this from the v0.88 milestone Jul 30, 2021
@bep bep added this to the v0.87 milestone Jul 30, 2021
@bep bep removed this from the v0.87 milestone Aug 1, 2021
@bep bep added this to the v0.88 milestone Aug 1, 2021
@bep bep removed this from the v0.88 milestone Aug 1, 2021
@bep bep added this to the v0.87 milestone Aug 1, 2021
@bep
Copy link
Member

@bep bep commented Aug 1, 2021

This has been resolved, and Hugo just needs to pull in the latest version of the library.

There is no version with this patch as far as I can see. Can you ask upstream for a new tagged version?

@bwklein
Copy link
Contributor Author

@bwklein bwklein commented Aug 1, 2021

I've made the request.

jmooring added a commit to jmooring/hugo that referenced this issue Aug 2, 2021
@jmooring
deps: Update github.com/tdewolff/minify/v2 v2.9.20 => v2.9.21
4d62f71 
Closes gohugoio#8831
@jmooring jmooring mentioned this issue Aug 2, 2021
Merged
@bep bep closed this in #8840 Aug 2, 2021
bep added a commit that referenced this issue Aug 2, 2021
@jmooring @bep
deps: Update github.com/tdewolff/minify/v2 v2.9.20 => v2.9.21
Loading status checks…
9a7383c 
Closes #8831
@bot-actions bot-actions bot mentioned this issue Aug 4, 2021
Merged
@abtris abtris mentioned this issue Aug 9, 2021
Merged
@abtris abtris mentioned this issue Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.87
Linked pull requests

Successfully merging a pull request may close this issue.

deps: Update github.com/tdewolff/minify/v2 v2.9.20 => v2.9.21
2 participants
@bep @bwklein