Embed go timezone database in Windows build #8892
Labels
Milestone
Comments
|
One learns something new every day. We have tests that run on Windows, but those servers all have Go installed. I have pushed a fix for this, a fix I don't have any easy way to verify myself. I assume it will work, but it would be good if someone could chime in and tell me that it works. |
|
I could test, but I'm not a Go programmer, so if you provide the v0.88-dev build, I'll check on Win7 and 10. |
|
@malcom attached is the dev build (extended version) for Windows. |
|
I tested and confirm that it works correctly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hugo87 with specified
timeZonein config exit on Windows with msg:This is a known problem with golang time lib on Windows (golang/go#21881, golang/go#38453) with missing
zoneinfo.zipfile.User workaround for this problem could be:
zoneinfo.zipfile from golang distribution and set the path for it in env%ZONEINFO%But, it seems a much better solution would be to embed the binary content of this file when building the windows version. Package tzdata provides an embedded copy of the timezone database.
The text was updated successfully, but these errors were encountered: