Skip to content

/ hugo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fsnotify 1.5.0 breaks symlink changes #8920

Closed
pamubay opened this issue Aug 23, 2021 · 2 comments
Closed

Fsnotify 1.5.0 breaks symlink changes #8920

pamubay opened this issue Aug 23, 2021 · 2 comments
Labels
Upstream

Comments

@pamubay
Copy link

@pamubay pamubay commented Aug 23, 2021

What version of Hugo are you using (hugo version)?

hugo v0.88.0-DEV-7A15EDAF+extended linux/amd64 BuildDate=2021-08-23T20:18:48+0700

Does this issue reproduce with the latest release?

Yes, it's build latest from source.

Project Structure

I have my-theme as symbolic link.

config.yaml
content/
themes/
  my-theme/ --> Symbolic Link

Bug

If you change anything under my-theme directory, Hugo detect the modification (trigger rebuild) but didnt't grab the changes of file content.

Workaround

I downgraded fsnotify to 1.4.9, everything works perfectly.
@bep bep closed this in 5a46eef Aug 23, 2021
@bep bep mentioned this issue Aug 23, 2021
Open
@bep bep reopened this Aug 23, 2021
@bep bep changed the title Hugo didn't grab changes from symbolic link directory after fsnotify 1.5.0 update Fsnotify 1.5.0 breaks symlink changes Aug 23, 2021
@bep bep added the Upstream label Aug 23, 2021
@bep
Copy link
Member

@bep bep commented Aug 23, 2021

Thanks for that report, good to catch that before release. I did read the upstream release notes before I merged, ... Oh well.

@jmooring
Copy link
Contributor

@jmooring jmooring commented Aug 25, 2021

Resolved with fsnotify/fsnotify#394.

@jmooring jmooring closed this Aug 25, 2021
bep added a commit to bep/hugo that referenced this issue Aug 26, 2021
@bep
Revert "build(deps): bump github.com/fsnotify/fsnotify from 1.4.9 to …
Verified
This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
GPG key ID: 330E6E2BD4859D8F Learn about vigilant mode.
569d161 
…1.5.0"

This reverts commit f701652.

Closes gohugoio#8920
@bot-actions bot-actions bot mentioned this issue Sep 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Upstream
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@jmooring @bep @pamubay