Skip to content

/ hugo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check mycomponent.js vs mycomponent/index.js import resolution #8945

Closed
bep opened this issue Aug 31, 2021 · 0 comments
Closed

Check mycomponent.js vs mycomponent/index.js import resolution #8945

bep opened this issue Aug 31, 2021 · 0 comments
Assignees
@bep
Labels
Bug NeedsInvestigation

Comments

@bep
Copy link
Member

@bep bep commented Aug 31, 2021

I'm having some gray hairs building AlpineJS v3 mounted inside /assets. Now I see that the failing component matches the naming above, so I suspect that's it. That is a very rare naming conflict, I would say, but I'm guessing ES has a defined import order.
@bep bep self-assigned this Aug 31, 2021
@bep bep mentioned this issue Sep 1, 2021
Closed
bep added a commit to bep/hugo that referenced this issue Sep 1, 2021
@bep
js: Fix import order for ./foo when both ./foo.js and ./foo/index.js …
Verified
This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
GPG key ID: 330E6E2BD4859D8F Learn about vigilant mode.
Loading status checks…
c8421dc 
…exists

This is in line with how both Node and ESBuild's native import resolver does it.

The ambiguous situations above were discovered trying to build AlpineJS v3.

Note that the above was never an issue if you used `./foo.js` and similar to import the component.

Fixes gohugoio#8945
@bep bep mentioned this issue Sep 1, 2021
Merged
@bep bep closed this in #8947 Sep 1, 2021
bep added a commit that referenced this issue Sep 1, 2021
@bep
js: Fix import order for ./foo when both ./foo.js and ./foo/index.js …
Loading status checks…
cf73cc2 
…exists

This is in line with how both Node and ESBuild's native import resolver does it.

The ambiguous situations above were discovered trying to build AlpineJS v3.

Note that the above was never an issue if you used `./foo.js` and similar to import the component.

Fixes #8945
@bot-actions bot-actions bot mentioned this issue Sep 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bep bep

Labels
Bug NeedsInvestigation
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

js: Fix import order for ./foo when both ./foo.js and ./foo/index.js exists
1 participant
@bep