parser/metadecoders: Accumulate org keywords into arrays

[augustfengd]

Hey all! What are your thoughts on this change?

The keywords definition from the org syntax specification doesn't say we can't repeat keywords.

This change will also enable terms in org mode to have space.

Currently, repeated keywords are concatenated: #+title: foo\n#+title: bar would render as foo bar. With this change, it just doesn't render anything but hugo is not crashing either.

[jmooring]

From this project's README:

... create a proposal. Do not submit a pull request until the project lead accepts the proposal.

We first need to decide if we want to do this. This introduces yet another feature (multi-word strings) that is not natively supported by org mode.

[augustfengd]

Hey @jmooring, I've a created a proposal. Thanks for the advice.

I would just note that multi-word strings are natively supported in org mode, otherwise something as #+title: foo bar baz would not work.

[jmooring]

You have a repeated condition here.

[augustfengd]

Oh my, thanks for catching that. I've just fixed the commit.

[jmooring]

Test site:

git clone --single-branch -b hugo-github-issue-11743 https://github.com/jmooring/hugo-testing hugo-github-issue-11743
cd hugo-github-issue-11743
hugo server

[augustfengd]

I've separated the patch into two commits. Do let me know if I should rebase them into one, though.

[jmooring]

Please squash the commits, and change the commit message per these guidelines:
https://github.com/gohugoio/hugo/blob/master/CONTRIBUTING.md#git-commit-message-guidelines

For example:

parser/metadecoders: Allow multiword elements in Org mode arrays

Closes #11743

[augustfengd]

Amazing, thanks for the hint. I've just squashed the commits.

[jmooring]

@bep I am in favor of merging this. The only users that will be negatively affected are those who have been ignoring a related warning for the past 4.5 years.