Add md5 and sha1 template functions #1932

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@digitalcraftsman
Member

digitalcraftsman commented Mar 7, 2016

Fixes #1910.

@digitalcraftsman

This comment has been minimized.

Show comment
Hide comment
@digitalcraftsman

digitalcraftsman Mar 7, 2016

Member

@bep since the template functions' name would conflict with the corresponding package names I added an _ as prefix. Let me know if you're not happy with the way how the conflict is handled.

Member

digitalcraftsman commented Mar 7, 2016

@bep since the template functions' name would conflict with the corresponding package names I added an _ as prefix. Let me know if you're not happy with the way how the conflict is handled.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 7, 2016

Member

an _ as prefix.

That's fine. But you might add the error case to the tests (see the expect false interface{} construct used elsewhere).

Also add the two functions to the "smoke test at the top of the file".

Member

bep commented Mar 7, 2016

an _ as prefix.

That's fine. But you might add the error case to the tests (see the expect false interface{} construct used elsewhere).

Also add the two functions to the "smoke test at the top of the file".

@digitalcraftsman

This comment has been minimized.

Show comment
Hide comment
@digitalcraftsman

digitalcraftsman Mar 7, 2016

Member

I updated the test file accordingly.

Member

digitalcraftsman commented Mar 7, 2016

I updated the test file accordingly.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 10, 2016

Member

Merged in 94c3825

Member

bep commented Mar 10, 2016

Merged in 94c3825

@bep bep closed this Mar 10, 2016

@digitalcraftsman

This comment has been minimized.

Show comment
Hide comment
Member

digitalcraftsman commented Mar 10, 2016

Thanks.

@digitalcraftsman digitalcraftsman deleted the digitalcraftsman:tplfuncs/hashing branch Mar 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment