New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing to pick a specific file out of a gist. #1955

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@sprig
Contributor

sprig commented Mar 11, 2016

This change would allow one to pick a specific file to embed out of a multifile gist.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Mar 11, 2016

CLA assistant check
All committers have accepted the CLA.

CLAassistant commented Mar 11, 2016

CLA assistant check
All committers have accepted the CLA.

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Mar 11, 2016

Contributor

Please update docs/content/extras/shortcodes.md

Contributor

moorereason commented Mar 11, 2016

Please update docs/content/extras/shortcodes.md

@sprig

This comment has been minimized.

Show comment
Hide comment
@sprig

sprig Mar 11, 2016

Contributor

done.

Contributor

sprig commented Mar 11, 2016

done.

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Mar 11, 2016

Contributor

lgtm

Contributor

moorereason commented Mar 11, 2016

lgtm

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 11, 2016

Member

Looks good to me, too. Could you squash the 3 commits into one?

Member

bep commented Mar 11, 2016

Looks good to me, too. Could you squash the 3 commits into one?

@sprig

This comment has been minimized.

Show comment
Hide comment
@sprig

sprig Mar 11, 2016

Contributor

Done.

Contributor

sprig commented Mar 11, 2016

Done.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 11, 2016

Member

Could you also fix the commit message (see guidelines).

Member

bep commented Mar 11, 2016

Could you also fix the commit message (see guidelines).

@sprig

This comment has been minimized.

Show comment
Hide comment
@sprig

sprig Mar 11, 2016

Contributor

I hope this is better?

Contributor

sprig commented Mar 11, 2016

I hope this is better?

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 11, 2016

Member

"better" is subjective, but it is correct.

Member

bep commented Mar 11, 2016

"better" is subjective, but it is correct.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 11, 2016

Member

Merged in e9008b9 thanks for the contrib.

Member

bep commented Mar 11, 2016

Merged in e9008b9 thanks for the contrib.

@bep bep closed this Mar 11, 2016

@sprig

This comment has been minimized.

Show comment
Hide comment
@sprig

sprig Mar 11, 2016

Contributor
Contributor

sprig commented Mar 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment