New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alias redirect output URL's relative #2093

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@SvenDowideit
Contributor

SvenDowideit commented Apr 19, 2016

we use relativeURLs = true

Before the change, hugo output the BaseURL - which prevents us from moving the html around

Sven Dowideit@DESKTOP-5ACOFLK MINGW64 ~/src/docker/docs (master)
$ curl http://localhost:1313/engine/reference/logging/awslogs/
<!DOCTYPE html><html><head><link rel="canonical" href="http://localhost:1313/engine/admin/logging/awslogs/"/><meta http-equiv="content-type" content="text/html; charset=utf-8" /><meta http-equiv="refresh" content="0;url=http://localhost:1313/engine/admin/logging/awslogs/" /></head></html>
Sven Dowideit@DESKTOP-5ACOFLK MINGW64 ~/src/docker/docs (master)

This PR changes the output to:

Sven Dowideit@DESKTOP-5ACOFLK MINGW64 ~/src/docker/docs (master)
$ curl http://localhost:1313/engine/reference/logging/awslogs/
<!DOCTYPE html><html><head><link rel="canonical" href="../../../admin/logging/awslogs/"/><meta http-equiv="content-type" content="text/html; charset=utf-8" /><meta http-equiv="refresh" content="0;url=../../../admin/logging/awslogs/" /></head></html>
Sven Dowideit@DESKTOP-5ACOFLK MINGW64 ~/src/docker/docs (master)
Make alias redirect output URL's relative
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@SvenDowideit

This comment has been minimized.

Show comment
Hide comment
@SvenDowideit

SvenDowideit Apr 21, 2016

Contributor

@spf13 @bep what do you think?

Contributor

SvenDowideit commented Apr 21, 2016

@spf13 @bep what do you think?

@bep bep closed this in 22683a3 Apr 22, 2016

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Apr 22, 2016

Member

Looks good, but for the future it would be nice if you could skip the "Signed off by ..." in the commit message body.

Member

bep commented Apr 22, 2016

Looks good, but for the future it would be nice if you could skip the "Signed off by ..." in the commit message body.

@SvenDowideit SvenDowideit deleted the SvenDowideit:make-redirects-relative branch Apr 22, 2016

tychoish added a commit to tychoish/hugo that referenced this pull request Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment