New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded casts in page.getParam #2186

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@sambooo
Contributor

sambooo commented Jun 6, 2016

Some calls to cast.To in getParam are no-ops that can be removed, since they just add type information that is discarded on return

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jun 6, 2016

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Jun 6, 2016

CLA assistant check
All committers have signed the CLA.

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Jun 6, 2016

Contributor

Curious how you found these. Are you using a linter?

Contributor

moorereason commented Jun 6, 2016

Curious how you found these. Are you using a linter?

@sambooo

This comment has been minimized.

Show comment
Hide comment
@sambooo

sambooo Jun 6, 2016

Contributor

Just caught my eye when looking at Page's implementation. Why do you ask?

Contributor

sambooo commented Jun 6, 2016

Just caught my eye when looking at Page's implementation. Why do you ask?

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Jun 6, 2016

Contributor

Then you have a good eye. 👍 I was asking about the linter because I don't know of an existing linter that would detect that issue.

lgtm

Contributor

moorereason commented Jun 6, 2016

Then you have a good eye. 👍 I was asking about the linter because I don't know of an existing linter that would detect that issue.

lgtm

@sambooo

This comment has been minimized.

Show comment
Hide comment
@sambooo

sambooo Jun 6, 2016

Contributor

Force pushed to my fork like an idiot and got another commit stuck in the mix, no changes in the new version

Contributor

sambooo commented Jun 6, 2016

Force pushed to my fork like an idiot and got another commit stuck in the mix, no changes in the new version

@bep bep closed this in 75deb92 Jun 9, 2016

tychoish added a commit to tychoish/hugo that referenced this pull request Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment