New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortcode in markdown headers #2210

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bep
Member

bep commented Jun 13, 2016

This issue was introduced as a fix to shortcode not working in RST.

One could argue that Blackfriday and friends should handle # in titles, but that will be a discussion
for another day.

The new placeholder pattern should be RST safe and work with titles.

And now with a test so this doesn't break again.

Fixes #2192
Fixes #2209

Fix shortcode in markdown headers
This issue was introduced as a fix to shortcode not working in RST.

One could argue that Blackfriday and friends should handle `#` in titles, but that will be a discussion
for another day.

The new placeholder pattern should be RST safe and work with titles.

And now with a test so this doesn't break again.

Fixes #2192
Fixes #2209

@bep bep added the NeedsReview label Jun 13, 2016

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jun 13, 2016

Member

See #1904 for the RST issue.

Member

bep commented Jun 13, 2016

See #1904 for the RST issue.

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Jun 15, 2016

Contributor

lgtm

Contributor

moorereason commented Jun 15, 2016

lgtm

@bep bep closed this in 34f4004 Jun 15, 2016

@bep bep deleted the bep:shortcodeintitles branch Apr 18, 2017

tychoish added a commit to tychoish/hugo that referenced this pull request Aug 13, 2017

Fix shortcode in markdown headers
This issue was introduced as a fix to shortcode not working in RST.

One could argue that Blackfriday and friends should handle `#` in titles, but that will be a discussion
for another day.

The new placeholder pattern should be RST safe and work with titles.

And now with a test so this doesn't break again.

Fixes gohugoio#2192
Fixes gohugoio#2209
Closes gohugoio#2210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment