New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automatic page date fallback #2239

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@vbatoufflet
Contributor

vbatoufflet commented Jun 27, 2016

Hi,

This PR adds an automatic value for Page.Date using the file's ModTime as fallback when none is provided?

Please let me know if it suits to you.

Regards.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Jun 27, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vincent Batoufflet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

CLAassistant commented Jun 27, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vincent Batoufflet seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jun 27, 2016

Member

I guess this is a fair compromise.

Member

bep commented Jun 27, 2016

I guess this is a fair compromise.

@bep

View changes

Show outdated Hide outdated hugolib/page.go Outdated
@vbatoufflet

This comment has been minimized.

Show comment
Hide comment
@vbatoufflet

vbatoufflet Jun 28, 2016

Contributor

Hi,

Thanks for the feedback. I just updated my PR to use hugofs.

Contributor

vbatoufflet commented Jun 28, 2016

Hi,

Thanks for the feedback. I just updated my PR to use hugofs.

@bep bep closed this in eda3678 Jun 28, 2016

@luixxiul

This comment has been minimized.

Show comment
Hide comment
@luixxiul

luixxiul Jul 1, 2016

This causes a trouble if you are using Page in terms of WordPress: about/sitemap/privacy policy/etc which do not have .Date suddenly start to appear in feeds or the list of recent posts.

luixxiul commented Jul 1, 2016

This causes a trouble if you are using Page in terms of WordPress: about/sitemap/privacy policy/etc which do not have .Date suddenly start to appear in feeds or the list of recent posts.

@vbatoufflet

This comment has been minimized.

Show comment
Hide comment
@vbatoufflet

vbatoufflet Jul 1, 2016

Contributor

Hi all,

Maybe we can define a configuration option to toggle automatic date feature?

WDYT?

Contributor

vbatoufflet commented Jul 1, 2016

Hi all,

Maybe we can define a configuration option to toggle automatic date feature?

WDYT?

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jul 1, 2016

Member

WDYT?

Yes, we need that, and set it to default = false. Could you create a PR?

Member

bep commented Jul 1, 2016

WDYT?

Yes, we need that, and set it to default = false. Could you create a PR?

@luixxiul

This comment has been minimized.

Show comment
Hide comment
@luixxiul

luixxiul Jul 1, 2016

That would be great!

2016/07/01 16:25 "Bjørn Erik Pedersen" notifications@github.com:

WDYT?

Yes, we need that, and set it to default = false.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

luixxiul commented Jul 1, 2016

That would be great!

2016/07/01 16:25 "Bjørn Erik Pedersen" notifications@github.com:

WDYT?

Yes, we need that, and set it to default = false.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@vbatoufflet

This comment has been minimized.

Show comment
Hide comment
@vbatoufflet

vbatoufflet Jul 1, 2016

Contributor

Yes, I will create a PR.

Contributor

vbatoufflet commented Jul 1, 2016

Yes, I will create a PR.

@vbatoufflet

This comment has been minimized.

Show comment
Hide comment
@vbatoufflet

vbatoufflet Jul 6, 2016

Contributor

Hi All,

Any suggestion on the setting name, e.g. AutomaticFallbackDates or AutoDates?

Contributor

vbatoufflet commented Jul 6, 2016

Hi All,

Any suggestion on the setting name, e.g. AutomaticFallbackDates or AutoDates?

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jul 6, 2016

Member

@vbatoufflet see my comment on #2244

Member

bep commented Jul 6, 2016

@vbatoufflet see my comment on #2244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment