New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added `htmlescape` and `htmlunescape` template functions #2287

Merged
merged 1 commit into from Jul 18, 2016

Conversation

Projects
None yet
2 participants
@cathalgarvey
Contributor

cathalgarvey commented Jul 18, 2016

See #2286

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jul 18, 2016

Member

Looks almost very good:

  1. The naming standard is camel casing, so it should be htmlEscape and htmlUnescape.
  2. Fix the commit message (add vs added)
Member

bep commented Jul 18, 2016

Looks almost very good:

  1. The naming standard is camel casing, so it should be htmlEscape and htmlUnescape.
  2. Fix the commit message (add vs added)
Add `htmlEscape` and `htmlUnescape` template functions
These functions allow trivial escaping and unescaping of HTML entities,
and make it far easier to compose other functions for the creation of
parameterised URLs.
@cathalgarvey

This comment has been minimized.

Show comment
Hide comment
@cathalgarvey

cathalgarvey Jul 18, 2016

Contributor

Sorry for that! Fixed, after some embarrassing rebase shenanigans.

Contributor

cathalgarvey commented Jul 18, 2016

Sorry for that! Fixed, after some embarrassing rebase shenanigans.

@bep bep merged commit 20555b1 into gohugoio:master Jul 18, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/wercker Wercker build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment