New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema org #2646

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@brunoamaral
Contributor

brunoamaral commented Oct 29, 2016

resolves gohugoio/hugo#2635 , Only show post's own keywords

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Oct 29, 2016

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Oct 29, 2016

CLA assistant check
All committers have signed the CLA.

@bep bep requested a review from digitalcraftsman Mar 13, 2017

@bep bep added the NeedsReview label Mar 13, 2017

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 13, 2017

Member

@digitalcraftsman Approving non-mergable PRs doesn't really bring us very much closer to resolving this PR.

Member

bep commented Mar 13, 2017

@digitalcraftsman Approving non-mergable PRs doesn't really bring us very much closer to resolving this PR.

@digitalcraftsman

This comment has been minimized.

Show comment
Hide comment
@digitalcraftsman

digitalcraftsman Mar 13, 2017

Member

Approving non-mergable PRs doesn't really bring us very much closer to resolving this PR.

Except that this PR needs to be rebased I approve the changes made to the internal template. What aspect makes this PR non-mergable?

Member

digitalcraftsman commented Mar 13, 2017

Approving non-mergable PRs doesn't really bring us very much closer to resolving this PR.

Except that this PR needs to be rebased I approve the changes made to the internal template. What aspect makes this PR non-mergable?

@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Mar 13, 2017

Member

What aspect makes this PR non-mergable?

It needs a rebase. I'm not saying you should do it, but someone could maybe ask the PR starter nicely? And that could maybe have been done as part of the "reviewing workflow". Not sure.

Member

bep commented Mar 13, 2017

What aspect makes this PR non-mergable?

It needs a rebase. I'm not saying you should do it, but someone could maybe ask the PR starter nicely? And that could maybe have been done as part of the "reviewing workflow". Not sure.

@moorereason

This comment has been minimized.

Show comment
Hide comment
@moorereason

moorereason Mar 13, 2017

Contributor

@brunoamaral, can you rebase this PR, please?

Contributor

moorereason commented Mar 13, 2017

@brunoamaral, can you rebase this PR, please?

@digitalcraftsman

This comment has been minimized.

Show comment
Hide comment
@digitalcraftsman

digitalcraftsman Mar 14, 2017

Member

It needs a rebase. I'm not saying you should do it, but someone could maybe ask the PR starter nicely? And that could maybe have been done as part of the "reviewing workflow". Not sure.

Because you requested a review from me I thought you just wished a second opinion for it. On the other hand it's would be good to have this PR already rebased to merge with a few clicks would be a good idea. On the other hand smaller changes that aren't affected by a large merge conflict could be merged with GitHubs automatic rebase feature. New commits that don't touch the part of the contribution at all shouldn't be a blocker for a PR.

Member

digitalcraftsman commented Mar 14, 2017

It needs a rebase. I'm not saying you should do it, but someone could maybe ask the PR starter nicely? And that could maybe have been done as part of the "reviewing workflow". Not sure.

Because you requested a review from me I thought you just wished a second opinion for it. On the other hand it's would be good to have this PR already rebased to merge with a few clicks would be a good idea. On the other hand smaller changes that aren't affected by a large merge conflict could be merged with GitHubs automatic rebase feature. New commits that don't touch the part of the contribution at all shouldn't be a blocker for a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment