New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugolib: Enable nested sections #3309

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
3 participants
@bep
Member

bep commented Apr 9, 2017

Fixes #465

See http://hugotest.bep.is/ for a demo site.

@bep bep added the InProgress label Apr 9, 2017

Show outdated Hide outdated hugolib/page.go
@bep

This comment has been minimized.

Show comment
Hide comment
@bep

bep Jun 4, 2017

Member

This is mostly done now, but a fair amount of TODOs in there that need to be handled.

Performance should be just about the same, looks slightlly faster:

▶ ./benchSite.sh "TOML,num_root_sections=5,num_pages=1000" 

github.com/spf13/hugo  master ✔                                                                                                                                                        19h30m
▶ benchcmp pre.bench post.bench
benchmark                                                           old ns/op     new ns/op     delta
BenchmarkSiteBuilding/TOML,num_root_sections=5,num_pages=1000-4     114543797     111523225     -2.64%

benchmark                                                           old allocs     new allocs     delta
BenchmarkSiteBuilding/TOML,num_root_sections=5,num_pages=1000-4     595315         602237         +1.16%

benchmark                                                           old bytes     new bytes     delta
BenchmarkSiteBuilding/TOML,num_root_sections=5,num_pages=1000-4     68144409      68539393      +0.58%
Member

bep commented Jun 4, 2017

This is mostly done now, but a fair amount of TODOs in there that need to be handled.

Performance should be just about the same, looks slightlly faster:

▶ ./benchSite.sh "TOML,num_root_sections=5,num_pages=1000" 

github.com/spf13/hugo  master ✔                                                                                                                                                        19h30m
▶ benchcmp pre.bench post.bench
benchmark                                                           old ns/op     new ns/op     delta
BenchmarkSiteBuilding/TOML,num_root_sections=5,num_pages=1000-4     114543797     111523225     -2.64%

benchmark                                                           old allocs     new allocs     delta
BenchmarkSiteBuilding/TOML,num_root_sections=5,num_pages=1000-4     595315         602237         +1.16%

benchmark                                                           old bytes     new bytes     delta
BenchmarkSiteBuilding/TOML,num_root_sections=5,num_pages=1000-4     68144409      68539393      +0.58%

@bep bep removed the InProgress label Jun 6, 2017

@bep bep changed the title from WIP: hugolib: Enable nested sections to hugolib: Enable nested sections Jun 6, 2017

@bep bep changed the title from hugolib: Enable nested sections to WIP hugolib: Enable nested sections Jun 6, 2017

@bep bep added the InProgress label Jun 6, 2017

Show outdated Hide outdated hugolib/site_sections.go
Show outdated Hide outdated hugolib/page.go
Show outdated Hide outdated hugolib/site_sections.go
Show outdated Hide outdated hugolib/site_sections.go
Show outdated Hide outdated hugolib/site_sections.go

@bep bep changed the title from WIP hugolib: Enable nested sections to hugolib: Enable nested sections Jun 8, 2017

@bep bep removed the InProgress label Jun 8, 2017

The requrested changes are applied.

@bep bep merged commit b396893 into gohugoio:master Jun 8, 2017

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment