New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dockerfile): xtrem awesome container size optimization #3738

Merged
merged 4 commits into from Jul 26, 2017

Conversation

Projects
None yet
2 participants
@ellerbrock
Contributor

ellerbrock commented Jul 25, 2017

Hi @anthonyfok,

i just ask myself:

cool or what?

Few days before we talked about size matters and how to optimize it in #3730.
We started with 428M and optimized it to 277M.
What would you say to make it even a little bit smaller and give you a 27M Container without waiting for any Docker releases and just do it the good old way?

hugo

cheers maik

@ellerbrock ellerbrock requested a review from anthonyfok as a code owner Jul 25, 2017

ellerbrock and others added some commits Jul 25, 2017

@anthonyfok

Wow, that's quite a neat trick you have there, @ellerbrock!
I didn't know alpine has an up-to-date go package, and I mistakenly thought that we would have to build Go from scratch, which would take a long time, and dismissed that idea. Good job! :-)

@anthonyfok anthonyfok merged commit bfe0bfb into gohugoio:master Jul 26, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@ellerbrock

This comment has been minimized.

Show comment
Hide comment
@ellerbrock

ellerbrock Jul 26, 2017

Contributor

hi @anthonyfok,

#9ed48c1 thats the spirit!
you really squeezed the last bits out for the optimization - great!

hey what do you guys think about making a official docker account for hugo?
i could help with the setup and maintain the docker stuff.
to be able to start doing that i guess i need at least be part of the team with read permission for the repo to create a automatic build. i have on my local machine some other useful things hacked together with docker-compose.yml which could be helpful for others as well (for example bring hugo server up, automatic compile sass and things like that ...).
maybe a own docker repo with some useful starter kits could be nice as well.
let me know when you guys talked about it ...

cheers maiky

Contributor

ellerbrock commented Jul 26, 2017

hi @anthonyfok,

#9ed48c1 thats the spirit!
you really squeezed the last bits out for the optimization - great!

hey what do you guys think about making a official docker account for hugo?
i could help with the setup and maintain the docker stuff.
to be able to start doing that i guess i need at least be part of the team with read permission for the repo to create a automatic build. i have on my local machine some other useful things hacked together with docker-compose.yml which could be helpful for others as well (for example bring hugo server up, automatic compile sass and things like that ...).
maybe a own docker repo with some useful starter kits could be nice as well.
let me know when you guys talked about it ...

cheers maiky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment