Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Taxonomy permalinks #4061

Merged
merged 1 commit into from Nov 7, 2017
Merged

Handle Taxonomy permalinks #4061

merged 1 commit into from Nov 7, 2017

Conversation

@betaveros
Copy link
Contributor

@betaveros betaveros commented Nov 7, 2017

Return the correct virtual Section for Taxonomy and TaxonomyTerm.
Restrict permalink expansion to only Pages and Taxonomies, but then
actually use expanded permalinks even for non-Pages.

Fixes #1208.

@moorereason
Copy link
Contributor

@moorereason moorereason commented Nov 7, 2017

Can you add tests?

Loading

@bep
Copy link
Member

@bep bep commented Nov 7, 2017

I suspect the lack of tests is because he is testing the waters as to "will this be merged". Yes, this looks good.

And it would look even better with a testcase or two (there should be a permalinks type of integration test somewhere that you can expand on) and some lines in the docs (in this repo).

Loading

Return the correct virtual Section for Taxonomy and TaxonomyTerm.
Restrict permalink expansion to only Pages and Taxonomies, but then
actually use expanded permalinks even for non-Pages.

Fixes gohugoio#1208.
@betaveros betaveros force-pushed the taxonomy-permalinks branch from f4870b3 to 46e3ddc Nov 7, 2017
@betaveros
Copy link
Contributor Author

@betaveros betaveros commented Nov 7, 2017

Should have tests and documentation now. I added the tests to taxonomy_test.go because it was convenient; let me know if you think it doesn't belong there.

Loading

@bep bep merged commit d9a78b6 into gohugoio:master Nov 7, 2017
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants