Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Handle Taxonomy permalinks #4061
I suspect the lack of tests is because he is testing the waters as to "will this be merged". Yes, this looks good.
And it would look even better with a testcase or two (there should be a permalinks type of integration test somewhere that you can expand on) and some lines in the docs (in this repo).