Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade to latest version of emoji dependency #6391

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@jamietanna
Copy link
Contributor

commented Oct 5, 2019

To add support for new emojis in Hugo, we need to upgrade our internal
dependency on the emoji package.

To add support for new emojis in Hugo, we need to upgrade our internal
dependency on the emoji package.
@CLAassistant

This comment has been minimized.

Copy link

commented Oct 5, 2019

CLA assistant check
All committers have signed the CLA.

@bep bep merged commit 170f18d into gohugoio:master Oct 5, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details
@bep

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Sorry, I fast a little bit fast merging this. I had to revert this due to related test failures. Could you create another one and run the tests?

jamietanna added a commit to jamietanna/hugo that referenced this pull request Oct 5, 2019
To add support for new emojis in Hugo, we need to upgrade our internal
dependency on the emoji package.

Note that we also need to update our tests, as the underlying emoji that
is rendered has changed.

Follow-up to gohugoio#6391. (170f18d and
2df5d20)
bep added a commit that referenced this pull request Oct 5, 2019
To add support for new emojis in Hugo, we need to upgrade our internal
dependency on the emoji package.

Note that we also need to update our tests, as the underlying emoji that
is rendered has changed.

Follow-up to #6391. (170f18d and
2df5d20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.