Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anaka theme uses /post/ and NOT /posts/ #958

Closed
wants to merge 1 commit into from

Conversation

@clemens-tolboom
Copy link
Contributor

clemens-tolboom commented Oct 29, 2019

This should solve #862

Not sure about the asciicast though :-(

This should solve #862 

Not sure about the **asciicast** though :-(
@davidsneighbour

This comment has been minimized.

Copy link
Contributor

davidsneighbour commented Oct 29, 2019

This is the documentation for Hugo, not for the Anaka theme. Please re-open where ever this applies to.

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

clemens-tolboom commented Oct 29, 2019

Ehm ... https://gohugo.io/getting-started/quick-start/#step-3-add-a-theme adds the theme then the page will never be displayed

@davidsneighbour

This comment has been minimized.

Copy link
Contributor

davidsneighbour commented Oct 29, 2019

Hmm, so the consensus seems to be that the folder should be the plural version of the post type but both versions (singular/plural) work. I would keep it consistent and maybe change the used sample theme for this or change it in Anaka?

@bep?

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

clemens-tolboom commented Oct 29, 2019

The themes I checked (trying to use) did not have concensus neither on structure nor plural form :-(

So I guess we should allow this PR

BUT what about this asciicast ... can we get rid of that or is that auto generated?

@budparr

This comment has been minimized.

Copy link
Contributor

budparr commented Oct 30, 2019

When Hugo was created I recall the docs being specific about the folder being singular. I'll see if I can find that.

@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

clemens-tolboom commented Oct 30, 2019

@budparr would changing anaka not impact all anaka users in an unsuspected way (renaming folder(s)?

This PR is only to make the quickstart work properly ;-)

@budparr

This comment has been minimized.

Copy link
Contributor

budparr commented Oct 30, 2019

I don't think it would be a good idea to change Ananke because there are a fair number of users out there.

I can't find much of a trace of Steve's way of naming folders. It was formerly singular (as I recall), but now I see people are using plural (some changes from this year). Personally I think site.com/post/post-name/ makes the most sense.

At the end of the day I think the docs outside of this particular how-to should be unopinionated about folder naming conventions, so it seems reasonable that themes would handle it differently

@bep

This comment has been minimized.

Copy link
Member

bep commented Oct 30, 2019

So, what the main section(s) is named in a theme will wary; post/posts/blog/foo... So if you're doing a where .Site.RegularPages ... on the home page it's recommended to query by the mainSections param:

https://gohugo.io/functions/where/#mainsections

A user can set this in the config if he/she wants, but Hugo will do some page counting to determine what's considered "the main".

@bep

This comment has been minimized.

Copy link
Member

bep commented Oct 30, 2019

So, I will not merge this. #862 is about something else, I think.

@bep bep closed this Oct 30, 2019
@clemens-tolboom

This comment has been minimized.

Copy link
Contributor Author

clemens-tolboom commented Oct 30, 2019

I guess something went wrong ... the quick start does not funciton as /posts/ are not 'rendered'

I should have filed a better summary :-( and refer to mentioned issue. My bad.

Thus this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.