New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme: techlog-simple #444

Closed
mazgi opened this Issue Oct 7, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@mazgi
Copy link

mazgi commented Oct 7, 2018

Theme submission

Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.

Link to my theme repository: [https://github.com/mazgi/hugo-theme-techlog-simple]

I made sure that...

  • the repository contains a good README.md describing my theme
  • an open source license has been added to LICENSE.md
  • all metadata have been added to theme.toml
  • screenshots have been added in the images/ folder with the required dimensions
  • in case I'm using a customized demo via the exampleSite folder that
    • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
    • the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
  • I tested my theme against the gohugoio/HugoBasicExample
    • I've checked the developer tools' console in my browser for error messages
  • in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

Feel free to ask questions. We're glad to help.

@onedrawingperday

This comment has been minimized.

Copy link
Member

onedrawingperday commented Oct 13, 2018

Hi @mazgi and thank you for your theme submission.

Your Example Site renders when I execute the Hugo Themes Build Script 👍

However you need to do the following changes to take your submission further:

  • You need to include some basic information about your theme in the README not just the link to your demo, such as a brief description about its features and also a link to your theme's license. See here for an example: https://github.com/budparr/gohugo-theme-ananke/blob/master/README.md
  • Your theme's screenshots do not have the correct dimensions and also you should make sure to remove transparency. See: https://github.com/gohugoio/hugoThemes#media
  • You really need to remove the Amazon affiliate code links from the content files of your Example Site. We do not accept affiliate links on the Hugo website.

Please do the above and let me know so that I can look into your theme further.

@stale

This comment has been minimized.

Copy link

stale bot commented Nov 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. Feel free to ask questions. We're glad to help.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Nov 24, 2018

mazgi added a commit to mazgi/hugo-theme-techlog-simple that referenced this issue Nov 26, 2018

mazgi added a commit to mazgi/hugo-theme-techlog-simple that referenced this issue Nov 26, 2018

@mazgi

This comment has been minimized.

Copy link

mazgi commented Nov 26, 2018

Hi @onedrawingperday

Thank you for your review and advice.
I've just fixed it!
https://github.com/mazgi/hugo-theme-techlog-simple

@stale stale bot removed the Stale label Nov 26, 2018

@onedrawingperday

This comment has been minimized.

Copy link
Member

onedrawingperday commented Nov 26, 2018

Hello @mazgi
Thank you for making the changes! 👍

@digitalcraftsman
The Techlog Simple theme is ready to be added to the website.

@digitalcraftsman

This comment has been minimized.

Copy link
Member

digitalcraftsman commented Nov 29, 2018

Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment