Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme: Hermit #453

Closed
10 tasks done
Track3 opened this issue Oct 23, 2018 · 3 comments
Closed
10 tasks done

New theme: Hermit #453

Track3 opened this issue Oct 23, 2018 · 3 comments

Comments

@Track3
Copy link
Task lists! Give feedback

@Track3 Track3 commented Oct 23, 2018

Theme submission

Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.

Link to my theme repository: https://github.com/Track3/hermit

I made sure that...

  • the repository contains a good README.md describing my theme
  • an open source license has been added to LICENSE
  • all metadata have been added to theme.toml
  • screenshots have been added in the images/ folder with the required dimensions
  • in case I'm using a customized demo via the exampleSite folder that
    • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
    • the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
  • I tested my theme against the gohugoio/HugoBasicExample
    • I've checked the developer tools' console in my browser for error messages
  • in case my theme is using Hugo Pipes features like toCSS and PostCSS that I have committed the /resources directory with all generated assets, for my theme to work in the basic version of Hugo

Feel free to ask questions. We're glad to help.

@onedrawingperday
Copy link
Contributor

@onedrawingperday onedrawingperday commented Oct 23, 2018

@Track3 thank you very much for sharing your theme with the Hugo community!

Everything renders fine on my end! 🥇

@digitalcraftsman This theme is ready to be added to the website.

It is a single-column theme with good typography and vector assets. It is lightweight and it doesn't rely on a third party framework. Also it makes use of Hugo Pipes and it has zero third party requests.

@Track3
Copy link
Author

@Track3 Track3 commented Oct 23, 2018

Great! Thanks for the review, @onedrawingperday ! 👍

@digitalcraftsman
Copy link
Member

@digitalcraftsman digitalcraftsman commented Nov 19, 2018

Hello @Track3,

thank you for sharing this theme with the Hugo community. Your theme should be listed soon on the themes site.

Furthermore, I'll promote your theme on Hugo's official Twitter account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants