Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos with empty homepage and/or wrong posts list #682

Open
onedrawingperday opened this issue Aug 16, 2019 · 135 comments · Fixed by mikeblum/hugo-now#5

Comments

@onedrawingperday
Copy link
Contributor

commented Aug 16, 2019

Due to the nature of the changes that were introduced in Hugo v.0.57.0 (briefly described in #678 (comment)) a great number of theme demos now display empty homepages and/or post lists that point to section lists (instead of individual posts).

The solution to the problem would be the use of mainSections for theme lists on the homepage (as we have been advocating for a while now) as well the following (or its variations) in list templates:

{{ $pages := .Pages }}
{{ if .IsHome }}
{{ $pages = .Site.RegularPages }}
{{ end }}
{{ $paginator := .Paginate $pages }}

Hugo v.0.58.0 was released on the 4th of September 2019 and the breaking changes to the home.Pages collection that were reverted in 0.57.2 have been re-introduced Theme authors need to issue the fixes described above if they wish to keep their themes listed in the Hugo Showcase.


- Broken themes will be removed around the end of September -

Also note that #668 is in progress and the guidelines for maintaining a theme in the Hugo Showcase are about to change. Theme authors are encouraged to track this issue.

- If you no longer plan to maintain a theme please let us know -

Furthermore there is a related notice in the forum to alert theme authors about the breaking changes.

Below is the full list of affected themes (I have not included the few themes whose authors are working on a fix as mentioned in #678 ):

  1. Midnight @Shadow53
    Hugo Future Imperfect Slim fixed in pacollins/hugo-future-imperfect-slim@afbf3cc
    Yignyang fixed in joway/hugo-theme-yinyang@5091a6c
    Hugo Flex fixed in de-souza/hugo-flex@0d64b46
    Hugo Lamp fixed in huyb1991/hugo-lamp@b4408fd
  2. Cocoa-EH fix in progress see: mtn/cocoa-eh-hugo-theme#138
    Dream fixed in g1eny0ung/hugo-theme-dream@dbf0c47
    Zen fixed in frjo/hugo-theme-zen@a942441
    Bingo fixed in gundamew/hugo-bingo@ea9283f
  3. OneDly Project @cdeck3r
    Alpha Church fixed (see #687 )
    Minimage fixed in d-kusk/minimage@959ef80
    Tikva fixed in geschke/hugo-tikva@af5722f
  4. Simple Blox @okabrionz
  5. Hurock @TiTi
    Aether fixed in josephhutch/aether@0cf324b
    Binario fixed in Vimux/Binario@9f5ca76
    Newsprint theme removed in #685
    Indigo fixed in AngeloStavrow/indigo@a824342
    eiio fixed in leonhe/hugo_eiio@cc47f86
    Base 16 fixed in htdvisser/hugo-base16-theme@861b48a
    Black & Light fixed in davidhampgonsalves/hugo-black-and-light-theme@4168cd6
  6. Start Bootstrap Clean Blog @UtkarshVerma
    Niello fixed in guangmean/Niello@cc55110
    Massively fixed in curtistimson/hugo-theme-massively#72
    Hyde-Hyde fixed as per htr3n/hyde-hyde@ad9701b
    Techlog Simple fixed in mazgi/hugo-theme-techlog-simple@fdf9ccb
  7. Arabica @nirocfz
    Ezhil fixed in vividvilla/ezhil@3154483 and vividvilla/ezhil@bb28e76
  8. Yinwang @chinanf-boy
    Inkblotty fixed in tosi29/inkblotty@a2b99bd
    Paper fixed in nanxiaobei/hugo-paper@68a57bb
    Cayman fixed in zwbetz-gh/cayman-hugo-theme@c5c1915
  9. Athena fix in progress see: mtn/athena-hugo-theme#4
    Manis fixed in yursan9/manis-hugo-theme@30ff78a
    Ghostwriter fixed in jbub/ghostwriter@6e9eabc
  10. Hugo Nuo @laozhu
    Even fixed in olOwOlo/hugo-theme-even@5a3e559
  11. Hyde Y @enten
    Air fixed in syui/hugo-theme-air@3bc80b5
    Simplicity fixed in #687
    Beautiful Hugo fixed in halogenica/beautifulhugo@1d75ccd
    Changelog Theme fixed in jsnjack/hugo-changelog-theme@b94a13b
    Dusky Neon Potato fix in VVelox/hugo-dusky-neon-potato@a9bd193
  12. Blackburn @yoshiharuyamashita
    Paper CSS fixed in zwbetz-gh/papercss-hugo-theme@698fe6a
    Hyde fixed see: spf13/hyde@3080504
  13. Zozo @imzeuk
    Techdoc whitelisted in #691
    Adam & Eve fixed in blankoworld/hugo_theme_adam_eve@e925bcd
    Charaka fixed in natarajmb/charaka-hugo-theme@de01c10
    Hugo Apps Theme fixed in #687
  14. Mondrian @redraw
  15. Spectrum @silvanocerza
    XMin fixed in yihui/hugo-xmin@6123be2
  16. Pickles @mismith0227
  17. Castanet the author replied - (also see 863c677)
    Hamburg fixed in hauke96/hugo-theme-hamburg@3368d99
    Pacman fixed in coderzh/hugo-pacman-theme@ea7d497
  18. Shapez @djuelg
  19. Dream Plus @UtkarshVerma
    Lanyon fixed in tummychow/lanyon-hugo@33ecb36
  20. Hugo NES Classic (notified author in rjayasinghe/hugo-nes-classic#2 because it was impossible to tag him here)
    Pixyll fixed in azmelanar/hugo-theme-pixyll@c25f592
    [Minimal Bootstrap Hugo Theme fixed in zwbetz-gh/minimal-bootstrap-hugo-theme@634920a
    Kiss fixed in ribice/kiss@7ea3147
  21. Hugo Bootstrap Premium @appernetic
    Hugo Dusk fixed in gyorb/hugo-dusk@b0d2bc7
    Hugo W3 Simple fixed in jesselau76/hugo-w3-simple@601d63c
  22. Bleach @digivend
    Now UI fixed in cboettig/hugo-now-ui@82c3eb0
    Travelify fixed in balaramadurai/hugo-travelify-theme@65f7a10 - also whitelisted in #691
  23. dockDock @vjeantet
    hugo h5bp fixed in garvincasimir/hugo-h5bp-simple@f6b0f3a
    Herring Cove removed in e736afe
    Hugo Minimalist SPA fixed in #683
    Lithium fixed in jrutheiser/hugo-lithium-theme@fba4893
    Beg Unmaintained theme removed in #690
    81. Den fixed in shaform/hugo-theme-den@553b158 - (also see: #687 )
    Robotico whitelisted in #691
  24. Simple Hugo Theme @Xzya
    Silhouette fixed in mattbutton/silhouette-hugo@be305fb
    Octopress fixed in parsiya/Hugo-Octopress@3f80dea
  25. Hugo Bootstrap @Xzya
    Bootstrap BP fixed in spech66/bootstrap-bp-hugo-theme@68314b7
  26. Hugo multi Bootswatch
    Oldnew Mashup whitelisted in #691
    Er fixed in lingxz/er@ebdb186
    Hugo Grapes fixed in shankar/hugo-grapes@af4af64
    Hugo Classic fixed in goodroot/hugo-classic@bafd650
    Hugo Now fixed in mikeblum/hugo-now#5
    Dark Simplicity fix in kritoke/darksimplicity@e00dc41 and kritoke/darksimplicity@d516015
    Internet Weblog fixed in jnjosh/internet-weblog@2fa06ec
    Simple A fixed in AlexFinn/simple-a@b22f385
    Finite fixed in lambdafu/hugo-finite@105a665
    Rusty theme removed in #699
  27. Code Editor
    Hugo Cards the way this theme was refactored in bul-ikana/hugo-cards@e3248ef is not ideal, so I had to send #706 to cover this setup in the Build Script.
  28. Phugo
    Cocoa unmaintained removed in #680
  29. Potato Dark
  30. AllinOne
  31. Basics
  32. One
  33. Slim
    BeyondNothing fixed in salcan/BeyondNothing@2931c2a
  34. Martial Paper
  35. Would have been cool in the 80s
  36. Sublime Hugo
  37. Classless
    Landing Page unmaintained removed in #692
  38. Bootie Docs
    Hugo Frais fixed in the2ne/hugo-frais@cd01972 and the2ne/hugo-frais@056db8f
  39. Tracks
  40. Phlat
    Wave fixed in syui/hugo-theme-wave@68e2aed
    Paperback fixed in dashdashzako/paperback@9b58eba
  41. onetwothree
  42. Casper
  43. Casper Two
  44. Simpledoc Theme
    Elephants fixed in meibenny/elephants@7c40d2c
    Reveal JS whitelisted in #691
  45. Luxury Theme
    Gentoo removed in 7fdec13
  46. Retroful Hugo
  47. Strata - the maintainer is aware
    Liquorice fixed in eliasson/liquorice@4f2af3b
    Hikari fixed in digitalcraftsman/hugo-hikari-theme@314516a
  48. Minimalist - incorrect list - the maintainer is aware
    Journal removed in #694
  49. GitHub Project Page
  50. Red Lounge
  51. Steam - the maintainer is aware
  52. AMP
    Light Hugo fixed in tblyler/light-hugo@5ef28a4
  53. Icarus - the maintainer is aware
  54. Hugo Geo
  55. GoHugo AMP
  56. NeXT
    Hugo Scroll unmaintained and removed in #692
    Hugo Uno unmaintained and removed in #693
    Hugo Zen unmaintained and removed in #693
  57. Heather Hugo
    Remark Twemoji removed in #690
    Remark Minion removed in #690
    Nixon removed in d46f2d5 also see #682 (comment)
  58. Darkdoc
    Twenty Fourteen fixed in jaden/twentyfourteen@89e9097
  59. Angel's Ladder
  60. Hugo Bootswatch
  61. Rocktopus
    Gindoro removed in #690
  62. Projecthub
  63. Tachyons
    Shiori removed in #690
  64. Universal Theme @devcows
@frjo

This comment has been minimized.

Copy link

commented Aug 16, 2019

I believe I have fixed https://themes.gohugo.io/hugo-theme-zen/ now.

Thanks for the work keeping the Themes section updated and relevant!

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@frjo Thanks the theme demo will be fixed when @digitalcraftsman updates the themes in the repo.

@digitalcraftsman

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

The themes have been updated.

@Vimux

This comment has been minimized.

Copy link

commented Aug 16, 2019

The real impact of Hugo 0.57 breaking changes is even bigger than 155 themes, which stated above.

What about broken taxonomies list pages? As an example, Mainroad. This theme is not listed (because homepage works), but it's affected too. I am sure this is not a complete list of affected themes. I have three themes in themes.gohugo.io and all of them affected somehow: Binario, blank, Mainroad. And worst of all, it was done without notification or any warning.

I'll update my themes ASAP, but probably tomorrow, not today.

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

I'll update my themes ASAP, but probably tomorrow, not today.

There is a one month window so take your time.

Also please note that #668 is in progress and I suggest you track it because the guidelines for maintaining a theme in the Hugo Showcase are about to change..

We are a very small team and this is the last time that I spend an exorbitant amount of time running around notifying 155 people.

Thanks.

@curtistimson

This comment has been minimized.

Copy link

commented Aug 16, 2019

I've created a fix for the Massively theme and would appreciate a review if anyone has chance:

curtistimson/hugo-theme-massively#72

Thanks

@digitalcraftsman

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@onedrawingperday we could use Hugo's Twitter account to reach out to theme maintainers. Just let me know how to inform them in 280 characters.

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@digitalcraftsman

If you could tweet the following:

Theme authors you may want to check out https://github.com/gohugoio/hugoThemes/issues/682 to see if your theme is currently broken in Hugo v.057.1

@SamWhited

This comment has been minimized.

Copy link

commented Aug 16, 2019

FWIW, and I know I'm probably in the minority here, I do not have a Twitter account. Please also consider using email, or a blog or something I can subscribe to. Alternatively, has anyone considered stabilizing Hugo or at least getting on some sort of release cycle so that theme authors have a chance to fix things before breaking changes are released? Having them just kind of spring up after a release if you're not heavily involved in Hugo development doesn't feel great.

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@digitalcraftsman

Also note that currently I have hit a GitHub limit. It seems that only 50 user mentions are allowed per post. So I cannot notify more people in the first post of this topic and it will not be practical for me to open issues in the different theme repositories or mention them in comments further down.

I have contacted GitHub support for this, hopefully they will do something about it.

So I m giving this a rest until tomorrow.

@digitalcraftsman

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@SamWhited: FWIW, and I know I'm probably in the minority here, I do not have a Twitter account.

Twitter is only an additional channel to reach a wider audience. I think it's more effective and less effort to broadcast this information before contacting the developers individually. Of course we we probably won't reach every developer this way.

@yursan9

This comment has been minimized.

Copy link

commented Aug 16, 2019

Thank you for your hard work, @onedrawingperday ! I'll fix my theme ASAP

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@SamWhited

We are currently working on #668 and when that issue is resolved, we will put in writing that authors will need to keep an eye on current Hugo developments for making sure that a theme is functional with the latest version.

We always give theme developers a 30 day period for fixing issues and up until now I have been contacting people for problems out of my own time.

Breaking changes of the sort that happened in Hugo 0.57 are rare. Typically there is some kind of deprecation warning but in this case the changes in Pages Collections for the homepage etc. were done at once due to the development of new features like Cascading Front Matter.

@digitalcraftsman

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@SamWhited: Alternatively, has anyone considered stabilizing Hugo or at least getting on some sort of release cycle so that theme authors have a chance to fix things before breaking changes are released?

@bep is the lead developer behind Hugo. He should know best if a stable release cycle can be established and how the roadmap of Hugo will look like (incl. deprecations in future releases.)

To cite him from #678 (comment):

We could probably have dropped this home.Pages change, but since we had to introduce some other related breaking changes, I thought it was better to take all the pain at once ...

@digitalcraftsman

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@Leoj03

This comment has been minimized.

Copy link

commented Aug 16, 2019

The Universal theme is also suffering from the same issue.
Screenshot_2019-08-16_10-18-05

@SamWhited

This comment has been minimized.

Copy link

commented Aug 16, 2019

Twitter is only an additional channel to reach a wider audience. I think it's more effective and less effort to broadcast this information before contacting the developers individually. Of course we we probably won't reach every developer this way.

Yes, contacting each developer individually doesn't seem sustainable. That's why I suggested a mailing list or blog, everyone can use RSS or everyone has an email, but not everyone has a Twitter. Email is universal, so in my mind it's probably the best place to start.

@SamWhited

This comment has been minimized.

Copy link

commented Aug 16, 2019

This may also just be me, but just from reading the docs on the where page and from this post and the issue, I don't actually understand how to fix my theme. You suggest where site.RegularPages "Type" "in" site.Params.mainSectionsbut that gives me a list of sections (whereas before my blog home page was showing a list of pages). Should I be paginating over all pages in all those sections? Should I still filter on a hardcoded type within those sections? I don't really understand how a blog that before was just displaying pages of type "posts" or some other hardcoded thing can be created using this new mechanism.

@geschke

This comment has been minimized.

Copy link

commented Aug 16, 2019

@onedrawingperday Thanks for informing, I'll fix my theme "Tikva" in the next days.

Kind regards,
Ralf

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@SamWhited

I will look into your theme and let you know what you need to do in a bit.

@d-kusk d-kusk referenced this issue Aug 16, 2019
@eliasson

This comment has been minimized.

Copy link

commented Aug 28, 2019

Liquorice updated
eliasson/liquorice@4f2af3b

@panr

This comment has been minimized.

Copy link

commented Aug 29, 2019

I'm sorry if I've missed something in the issue's thread, but after changes in 0.57.x I wonder if we have to change minimum hugo version value in the theme config?

I've just got an user who had an earlier version (I don't know which one) and he claims that he got an error with can't evaluate field RegularPages in type *hugolib.pageState... After update to the latest version everything started to work again 😉

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

I wonder if we have to change minimum hugo version value in the theme config?

Yes you have to change it to "0.57.0"

@shankar

This comment has been minimized.

Copy link

commented Aug 30, 2019

Does this commit fix everything for hugo-grapes theme ?
shankar/hugo-grapes@af4af64

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2019

@shankar It looks OK. Thanks for the fixes.

coderzh added a commit to coderzh/hugo-pacman-theme that referenced this issue Aug 31, 2019
@coderzh

This comment has been minimized.

Copy link

commented Aug 31, 2019

hugo-pacman-theme updated:
coderzh/hugo-pacman-theme@ea7d497

@bul-ikana

This comment has been minimized.

Copy link

commented Sep 1, 2019

@dashdashzako

This comment has been minimized.

Copy link

commented Sep 2, 2019

  1. Paperback

Paperback theme should be fixed from dashdashzako/paperback@9b58eba.

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@dashdashzako

I commented in linked commit please let me know again when you address my feedback.

@mikeblum

This comment has been minimized.

Copy link

commented Sep 2, 2019

This should do the trick: mikeblum/hugo-now#5

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

@digitalcraftsman

Several authors have issued fixes, whenever you can please update the themes in the repo.

@digitalcraftsman

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

The themes have been updated.

@lambdafu

This comment has been minimized.

Copy link

commented Sep 3, 2019

I pushed a fix to lambdafu/hugo-finite@105a665, but I admit that I am only making minimal changes and probably not keeping up with best practices. If anybody wants to adopt the theme, let me know.

@halogenica

This comment has been minimized.

Copy link

commented Sep 5, 2019

I updated my theme, beautifulhugo should be working as of halogenica/beautifulhugo@1d75ccd

@ribice

This comment has been minimized.

Copy link

commented Sep 6, 2019

My theme kiss was updated with suggested changes from @onedrawingperday, but it still seems to be buggy using the latest version of hugo (0.58.0).

https://www.ribice.ba/

The index page is not build correctly, the blog pages are fine.

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

I am away @ribice and cannot debug this at the moment.

In ribice/kiss@7ea3147 you have hardcoded the mainSections parameter to "post" in your exampleSite’s config.

Do you have that section in your project?

By the way my advice above is that authors don’t need to specify the mainSections since Hugo detects them internally.

If one hardcodes mainSections in the configuration and what is entered in this array is not present in a project then there will be empty lists.

@ribice

This comment has been minimized.

Copy link

commented Sep 6, 2019

No I don't, and even after adding it the homepage is empty.

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@ribice please open a support ticket at the Hugo forum: https://discourse.gohugo.io/

Also make sure to post a link with your project’s source code so that people can see what’s going on.

I might have a look later today but also I might not since I am away. Posting at the forum is your best bet.

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@ribice I tested your theme's exampleSite with the latest Hugo 0.58.1 that was released today (6th Sep 2019) and everything is rendering fine on my end (i.e. the homepage features a list of posts)

The problem you mentioned above is not present in your theme, something else is going on with your project. If you need help ask in the Hugo forum.

@tosi29

This comment has been minimized.

Copy link

commented Sep 7, 2019

@onedrawingperday
Thank you for notification. I fixed inkblotty theme, and it looks working fine with hugo 0.58.1.
Thanks.

@olOwOlo

This comment has been minimized.

Copy link

commented Sep 8, 2019

  1. Even @olOwOlo

Thanks for notifying. Updated in olOwOlo/hugo-theme-even@5a3e559

@salcan

This comment has been minimized.

Copy link

commented Sep 8, 2019

@onedrawingperday made a minor update to https://github.com/salcan/BeyondNothing . Let me know if anything further is required and i'll dig into it. It's a very simple template so I never got too deep into the components, pagination etc. thanks

@vividvilla

This comment has been minimized.

Copy link

commented Sep 9, 2019

  1. Ezhil @vividvilla

Thanks for informing, I have fixed Ezhil on this commit - vividvilla/ezhil@bb28e76

@onedrawingperday

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

@vividvilla

Thanks for the fix. However there is no need to hardcode the mainSections parameter in your exampleSite’s config because you shouldn’t limit your users since mainSections are detected automatically. Also the HugoBasicExample that provides the demo content on the Hugo website does not have a “posts” section and your demo will still have an empty homepage as things are now. So please comment out the mainSections parameter from your config.

Please let me know when you do the above.

@vividvilla

This comment has been minimized.

Copy link

commented Sep 9, 2019

@onedrawingperday thanks for your prompt reply, I have made the required changes here - vividvilla/ezhil@3154483

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.