This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Aligned the "Minute" members of intraday and historical data points.
They appear to both be used the same way, as a string field that tells us the minute of the data point in the time zone of the exchange. I also removed, rather than update, a helper function that attempts to get the time from the historical data point by combining the date and minute fields. The problem is that this results in the wrong time because the time objects are in UTC, so to do this right you'd need to know the time zone which the "minute" value is in. I think we should leave it up to the consumer to write their methods to convert times according to their special circumstances.
- Loading branch information
Showing
2 changed files
with
22 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters