This repository has been archived by the owner on Jul 19, 2024. It is now read-only.
json: Handle empty HasPaywall data from News #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across an error parsing news (hasPaywall) - appearing to be missing data (empty string) for the following symbol:
2022/09/06 00:20:39 fetching news for PLMR
2022/09/06 00:20:39 json: cannot unmarshal string into Go struct field News.hasPaywall of type bool
It's possible that there should be some more extensive input checking, but this small struct tag update may fix the current existing issue. Apologies - this is my first ever fork/PR, but did run the requisite make (lint/int/etc) to