Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hystrix Client Exit on Hystrix Time-out Error #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaguecoder
Copy link

Motivation

Issue #127 reported by @sebastian-popa

Changes

  1. Condition to verify hystrix-timeout error and exit w/o retry. Add unit test to verify the same.
  2. Upgrade version of testify package: v1.3.0 -> v1.7.0 for assert.ErrorIs used by the same unit test.

Summary

Heimdall's hystrix-client once timed out on hystrix-go's client, the subsequent retries fail by throwing error similar to http: ContentLength=24 with Body length 0 as reported in #127. The code on #127 polished and shared at playground link to understand this.

cURL Call:

curl 'http://localhost:8080/proxy' -d'{"message": "anything"}'

Results:

# Before
{"message":"Post \"http://localhost:8080/actual\": http: ContentLength=24 with Body length 0"}

# Now
{"message":"hystrix: timeout"}

Related Issues

Closes #127

Signed-off-by: Bhargav Ravuri <vaguecoder0to.n@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hystrix POST with retry returns "http: ContentLength=... with Body length 0"
1 participant