Resolve Mainframer version during build. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vanniktech appreciate your interest and reviews 😽 |
arturdryomov
reviewed
Mar 1, 2018
| @@ -14,7 +14,7 @@ use std::time::Instant; | |||
| use time::*; | |||
|
|
|||
| fn main() { | |||
| println!(":: Mainframer v2.1.0\n"); | |||
| println!(":: Mainframer v{}\n", env!("CARGO_PKG_VERSION")); | |||
There was a problem hiding this comment.
How does it even work though? When runtime is packaged as a binary it exports environment variables itself?
There was a problem hiding this comment.
env! is a macro that compiler executes at build time, CARGO_PKG_VERSION is an environment variable provided by cargo to rustc during the build, so as a result we get version inlined into the code and binary
There was a problem hiding this comment.
These native folks will steal your soul eventually, you know. Avoid blood-involved rituals at all costs.
There was a problem hiding this comment.
lol, will try
btw Kotlin might get macros support eventually
arturdryomov
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #192.
Docs: https://doc.rust-lang.org/cargo/reference/environment-variables.html
Thanks @pepyakin for the link!