Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use http.FileSystem for all the things #144
Please address the issues I've raised here. It's fine to address those issues as a comment in this PR. e.g. doesn't need to be a comment in that github issue.
I don't see WebDAV source driver implementing the
I ran my own tests locally. I also ran your tests locally. The tests that are failing are something about a Cassandra timeout, which seems unrelated. Adding my own tests will not solve that problem as I don't use Cassandra and I wouldn't know how to test this specific functionality more than you and I already have.
This PR is a direct response to those issues. Please take a look at the code. The purpose of the code is to illustrate that by using Go's http.FileSystem` interface you support almost every file module that exists - including Packr.
WebDAV, the network transfer protocol, is not useful for this. However, the
We need tests for each source driver. Relying on existing tests to catch issues is not sufficient since we need to know if the driver we're depending on works or breaks with an update.
Ahh, I see now!
Are you familiar with other FS interfaces? I find it odd to use an FS interface from the