New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang: added ms-MY.json for Bahasa Malaysia in Malaysia (country) #157
Conversation
Codecov ReportBase: 99.89% // Head: 99.89% // No change to project coverage
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 18 18
Lines 2901 2901
=======================================
Hits 2898 2898
Misses 2 2
Partials 1 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
According to the name code standards of countries and regions in the world, I think it is better to name my-MS.json,such as 'zh-CN', 'en-CA' |
Noted. Updating it.. |
Since the i18n language is missing of Bahasa Malaysia for Malaysia while our other native languages (English [en], and Simplified Chinese [zh-CN]) are available, I, as a Malaysian who understands all these languages shall contribute the missing piece. The language code is 'ms' but 'MY' country code is required as the Bahasa Malaysia language itself is known closely related across the South East Asia coutries (variations in different countries like Singapore and Brunei). The only exception is Bahasa Indonesia where it has its own code (id). This patch adds ms-MY.json for Bahasa Malaysia specifically for Malaysia in South East Asia. Signed-off-by: (Holloway) Chew, Kean Ho <hollowaykeanho@gmail.com>
It is my-MS.json, not ms-MY.json, the country code should be put first. |
I'm confused. The language is
We're still following ISO 639 (e.g. https://www.venea.net/web/culture_code) right? Please double confirm. I can change it as per your request. |
Sorry, you are right. |
Since the i18n language is missing of Bahasa Malaysia for Malaysia while our other native languages (English [en], and Simplified Chinese [zh-CN]) are available, I, as a Malaysian who understands all these languages shall contribute the missing piece.
The language code is 'ms' but 'my' country code is required as the Bahasa Malaysia language itself is known closely related across the South East Asia coutries (variations in different countries like Singapore and Brunei). The only exception is Bahasa Indonesia where it has its own code (id).
This patch adds ms-my.json for Bahasa Malaysia specifically for Malaysia in South East Asia.
Signed-off-by: (Holloway) Chew, Kean Ho hollowaykeanho@gmail.com