Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header name to associate log entry & trace #263

merged 2 commits into from Dec 30, 2021


Copy link

Thanks for releasing v2.
I tried the log API on GAE 2nd gen, but it didn't associate with the request log.
The request header to get a trace id and a span id is correct X-Cloud-Trace-Context, not Cloud-Trace-Context.

@google-cla google-cla bot added the cla: yes label Sep 29, 2021
Copy link
Contributor Author

Can anyone please review this?

@KaylaNguyen KaylaNguyen self-assigned this Dec 23, 2021
Copy link

Thanks for the PR! Would you mind syncing this to head to try to trigger the ci tests?

Copy link
Contributor Author

Thanks for the review.
I've merged master to this fork.

@KaylaNguyen KaylaNguyen merged commit e005424 into golang:master Dec 30, 2021
16 checks passed
derat added a commit to derat/nup that referenced this pull request Apr 22, 2022
The current v2.0.1 release of
appears to have a bug where it doesn't set traces on
sturctured log entries, resulting in them not being attached
to HTTP requests in the GCP Console. It looks like this was
fixed by golang/appengine#263, so
update the package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants