Fix header name to associate log entry & trace #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone please review this? |
KaylaNguyen
approved these changes
Dec 29, 2021
|
Thanks for the PR! Would you mind syncing this to head to try to trigger the ci tests? |
|
Thanks for the review. |
derat
added a commit
to derat/nup
that referenced
this pull request
Apr 22, 2022
The current v2.0.1 release of google.golang.org/appengine/v2 appears to have a bug where it doesn't set traces on sturctured log entries, resulting in them not being attached to HTTP requests in the GCP Console. It looks like this was fixed by golang/appengine#263, so update the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Thanks for releasing v2.
I tried the log API on GAE 2nd gen, but it didn't associate with the request log.
The request header to get a trace id and a span id is correct
X-Cloud-Trace-Context, notCloud-Trace-Context.