Navigation Menu

Skip to content

Commit

Permalink
dashboard: skip dev.boringcrypto branches on most builders
Browse files Browse the repository at this point in the history
We care most about testing the dev.boringcrypto branches on linux/amd64.
Stop testing them on all builders, as it's not worth the resource use.

Continue to test on one additional non-linux/amd64 port,
namely windows/386, to ensure that fallbacks work.

Fixes golang/go#26791

Change-Id: I4556886f55175173de52e35cf57833b22843d586
Reviewed-on: https://go-review.googlesource.com/c/149739
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
  • Loading branch information
dmitshur committed Nov 15, 2018
1 parent 56e5e74 commit ac5b419
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions dashboard/builders.go
Expand Up @@ -869,6 +869,12 @@ func (c *BuildConfig) BuildBranch(repo, branch, goBranch string) bool {
return false
}
}
// Build dev.boringcrypto branches only on linux/amd64 and windows/386 (see golang.org/issue/26791).
if repo == "go" && (branch == "dev.boringcrypto" || strings.HasPrefix(branch, "dev.boringcrypto.")) {
if c.Name != "linux-amd64" && c.Name != "windows-386-2008" {
return false
}
}
return true
}

Expand Down

0 comments on commit ac5b419

Please sign in to comment.