Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/appengine: set GO111MODULE=on for deploy #23

Closed
wants to merge 1 commit into from

Conversation

@dmitshur
Copy link
Member

commented Sep 5, 2019

Deploying in GOPATH mode is not supported, so explicitly specify
GO111MODULE=on to use module mode regardless of local setup.

Fixes golang/go#34107

app/appengine: set GO111MODULE=on for deploy
Deploying in GOPATH mode is not supported, so explicitly specify
GO111MODULE=on to use module mode regardless of local setup.

Fixes golang/go#34107

@googlebot googlebot added the cla: yes label Sep 5, 2019

@gopherbot

This comment has been minimized.

Copy link

commented Sep 5, 2019

This PR (HEAD: 93f780c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/193597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot

This comment has been minimized.

Copy link

commented Sep 5, 2019

Message from Andrew Bonventre:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/193597.
After addressing review feedback, remember to publish your drafts!

@gopherbot

This comment has been minimized.

Copy link

commented Sep 5, 2019

Message from Alexander Rakoczy:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/193597.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 5, 2019
app/appengine: set GO111MODULE=on for deploy
Deploying in GOPATH mode is not supported, so explicitly specify
GO111MODULE=on to use module mode regardless of local setup.

Fixes golang/go#34107

Change-Id: I5bc2518c4cd4c329eea65684fec96aae5b0bf808
GitHub-Last-Rev: 93f780c
GitHub-Pull-Request: #23
Reviewed-on: https://go-review.googlesource.com/c/build/+/193597
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Sep 5, 2019

This PR is being closed because golang.org/cl/193597 has been merged.

@gopherbot gopherbot closed this Sep 5, 2019

@dmitshur dmitshur deleted the dmitshur:appengine-module-mode branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.