Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of support for Keccak hashing algorith #28

Closed
wants to merge 9 commits into from

Conversation

Projects
None yet
8 participants
@r8d8
Copy link

commented Sep 17, 2017

Current implementation lack of KECCAK hash function
Related to golang/go#19709

@gopherbot

This comment has been minimized.

Copy link

commented Sep 17, 2017

Hi! Thanks for the PR!

Unfortunately, the Go project doesn't use GitHub's Pull Requests,
so we can't accept your contribution this way.
We instead use a code review system called Gerrit.

The good news is, I'm here to help.

From here, you have two options:

  1. Read our Contribution Guidelines to learn how to send a change with Gerrit.
  2. Or, create an issue about the issue this PR addresses, so that someone else can fix it.

I'm going to close this Pull Request now.
Please don't be offended! :-)

Thanks again,

GopherBot (on behalf of the Go Team)

@gopherbot gopherbot closed this Sep 17, 2017

r8d8 added some commits Oct 11, 2017

Invalid algorithm in ed25519 keypair generation
Fixed, used Keccak and reversed byte order for hash input
@leonklingele

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2018

@r8d8 have you tried submitting this patch to https://go-review.googlesource.com/?

@jgillich

This comment has been minimized.

Copy link

commented Feb 9, 2018

+1 @r8d8 Please? :) This would be great to have.

@bradfitz bradfitz reopened this Feb 9, 2018

@googlebot

This comment has been minimized.

Copy link

commented Feb 9, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no label Feb 9, 2018

@andybons

This comment has been minimized.

Copy link
Member

commented Mar 1, 2018

Hey @r8d8 we just need you to sign the CLA and we can start review. Thanks!

@QuestofIranon

This comment has been minimized.

Copy link

commented Apr 11, 2018

+1 @r8d8 do you plan to sign it?

@leonklingele

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2018

As @r8d8 did not respond within three months, I've created #41.

@andybons andybons closed this Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.