New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep status is not useful if memo is out of date, not even a warning #161

Closed
kardianos opened this Issue Jan 25, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@kardianos

kardianos commented Jan 25, 2017

I've tried dep on a number of projects, some have main packages, others don't.

After I ran dep init, I expected dep status [-v, -detail, etc] to produce some list of packages. Each time I've gotten nothing.

At dep rev 1b193f4439655572d59fe1b87035870f1a7344ca

@kardianos

This comment has been minimized.

Show comment
Hide comment
@kardianos

kardianos Jan 25, 2017

Okay, so status won't show anything if the memo field is out of date.

kardianos commented Jan 25, 2017

Okay, so status won't show anything if the memo field is out of date.

@kardianos kardianos changed the title from dep status never shows any package list to dep status is not useful if memo is out of date, not even a warning Jan 25, 2017

@sdboyer

This comment has been minimized.

Show comment
Hide comment
@sdboyer

sdboyer Jan 26, 2017

Member

Yeah, dep status was one of the first things we implemented, and it's been largely neglected since. Some of that is because waiting on things in gps, but those things are almost all resolved now (sdboyer/gps#127 is the big outstanding one). In any case, though status really needs a full pass.

Would be a great place for someone really wanting to grok this thing/get their hands dirty to dig in 😃 😇

Member

sdboyer commented Jan 26, 2017

Yeah, dep status was one of the first things we implemented, and it's been largely neglected since. Some of that is because waiting on things in gps, but those things are almost all resolved now (sdboyer/gps#127 is the big outstanding one). In any case, though status really needs a full pass.

Would be a great place for someone really wanting to grok this thing/get their hands dirty to dig in 😃 😇

@sdboyer sdboyer referenced this issue Mar 2, 2017

Closed

(re)Spec and implement command set #277

8 of 8 tasks complete

kris-nova pushed a commit to kris-nova/dep that referenced this issue Apr 21, 2017

@darkowlzz

This comment has been minimized.

Show comment
Hide comment
@darkowlzz

darkowlzz Apr 30, 2017

Collaborator

Any suggestions on how we handle this behavior?

In case of outdated memo, shouldn't running status inform the user about outdated memo and ask to run ensure or provide information about how to fix it?

Also, under which scenarios the memo would not be updated and become outdated? Considering #470 would ensure memo is updated after init run.

Collaborator

darkowlzz commented Apr 30, 2017

Any suggestions on how we handle this behavior?

In case of outdated memo, shouldn't running status inform the user about outdated memo and ask to run ensure or provide information about how to fix it?

Also, under which scenarios the memo would not be updated and become outdated? Considering #470 would ensure memo is updated after init run.

@sdboyer

This comment has been minimized.

Show comment
Hide comment
@sdboyer

sdboyer May 1, 2017

Member

@darkowlzz status has really fallen by the wayside, which is unfortunate. i do have some sketched-out plans that, hopefully, i can translate into the doc in #277 for status soon, which should hopefully enable a more detailed discussion about it.

in general, though, if there's a memo mismatch (which can occur when a new import is added, an import is removed, or any values in Gopkg.toml are modified), then i think our goal is probably to detect the cause of the mismatch, and report it to the user.

Member

sdboyer commented May 1, 2017

@darkowlzz status has really fallen by the wayside, which is unfortunate. i do have some sketched-out plans that, hopefully, i can translate into the doc in #277 for status soon, which should hopefully enable a more detailed discussion about it.

in general, though, if there's a memo mismatch (which can occur when a new import is added, an import is removed, or any values in Gopkg.toml are modified), then i think our goal is probably to detect the cause of the mismatch, and report it to the user.

@sdboyer

This comment has been minimized.

Show comment
Hide comment
@sdboyer

sdboyer May 27, 2017

Member

@darkowlzz i think i just merged a PR from you...or there's one in flight...that addresses this?

Member

sdboyer commented May 27, 2017

@darkowlzz i think i just merged a PR from you...or there's one in flight...that addresses this?

@darkowlzz

This comment has been minimized.

Show comment
Hide comment
@darkowlzz

darkowlzz May 27, 2017

Collaborator

@sdboyer nope, I don't see the changes in master. It's #611 .

Collaborator

darkowlzz commented May 27, 2017

@sdboyer nope, I don't see the changes in master. It's #611 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment