New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/gps: parallelize WriteDepTree #1021

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
4 participants
@ibrasho
Copy link
Collaborator

ibrasho commented Aug 16, 2017

What does this do / why do we need it?

This commit updates WriteDepTree to parallelize write projects to the
vendor directory.

This change gives a decent speed boost when writing vendor directory.

What should your reviewer look out for in this PR?

Correctness.

Which issue(s) does this PR fix?

This somehow became part of #952 even though it's not really related. 馃榿

@ibrasho ibrasho requested a review from sdboyer as a code owner Aug 16, 2017

@googlebot googlebot added the cla: yes label Aug 16, 2017

internal/gps: parallelize WriteDepTree
This commit updates WriteDepTree to parallelize write projects to the
vendor directory.

Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>

@ibrasho ibrasho force-pushed the ibrasho-forks:parallelize-WriteDepTree branch from 1fa8a51 to 87bf819 Aug 16, 2017

@ibrasho

This comment has been minimized.

Copy link
Collaborator

ibrasho commented Aug 16, 2017

Running dep ensure from master takes ~9s with dep from master, but only ~1.5s with dep from this branch.

I tried dep ensure on github.com/cockroachdb/cockroach and it went down from taking ~78s to ~11s.

@sdboyer

This comment has been minimized.

Copy link
Member

sdboyer commented Aug 17, 2017

wow, that's way more of an improvement than i'd expected. spectacular!

@sdboyer sdboyer merged commit 2e1f284 into golang:master Aug 17, 2017

4 checks passed

cla/google All necessary CLAs are signed
codeclimate 1 fixed issue
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sdboyer sdboyer added the area: gps label Aug 17, 2017

@ibrasho ibrasho deleted the ibrasho-forks:parallelize-WriteDepTree branch Nov 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment