Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unresolved link in CONTRIBUTING.md #1281

Merged

Conversation

@budougumi0617
Copy link
Contributor

commented Oct 17, 2017

What does this do / why do we need it?

CONTRIBUTING.md cannot resolve below links.
dep_contributing_md_at_master_ _golang_dep

What should your reviewer look out for in this PR?

Please confirm these are correct links on browser.
https://github.com/budougumi0617/dep/blob/fix-unresoleved-link-in-markdown/CONTRIBUTING.md

Do you need help or clarification on anything?

Please tell me when I make a mistake

Which issue(s) does this PR fix?

None.

@budougumi0617 budougumi0617 requested a review from sdboyer as a code owner Oct 17, 2017
@googlebot googlebot added the cla: yes label Oct 17, 2017
@darkowlzz darkowlzz merged commit efd428f into golang:master Oct 17, 2017
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@darkowlzz

This comment has been minimized.

Copy link
Collaborator

commented Oct 17, 2017

Thanks for correcting them 👍

@budougumi0617 budougumi0617 deleted the budougumi0617:fix-unresoleved-link-in-markdown branch Oct 17, 2017
@budougumi0617

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2017

I appreciate your quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.