Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file extension to windows install #1755

Merged
merged 1 commit into from Mar 17, 2018

Conversation

Projects
None yet
3 participants
@g-harel
Copy link
Contributor

commented Mar 15, 2018

Which issue(s) does this PR fix?

fixes #1754

@g-harel g-harel requested a review from sdboyer as a code owner Mar 15, 2018

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.
1 similar comment
@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@googlebot googlebot added the cla: no label Mar 15, 2018

@g-harel

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2018

CLAs look good, thanks!

1 similar comment
@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Mar 15, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Mar 15, 2018

@ibrasho
Copy link
Collaborator

left a comment

LGTM

@ibrasho ibrasho merged commit 7d5cd19 into golang:master Mar 17, 2018

5 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
cla/google All necessary CLAs are signed
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@g-harel g-harel deleted the g-harel:install-windows-exe branch Mar 21, 2018

@g-harel g-harel restored the g-harel:install-windows-exe branch Mar 21, 2018

@g-harel g-harel changed the title Added file extension to windows install Add file extension to windows install Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.